[staging] Revert "python39: 3.9.6 -> 3.9.7" #141105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d003f75. Causes an unnecessary amount of breakages due to a DeprecationWarning regarding the loop argument in asyncio, that is going to be deprecrated in Python 3.10. > 'The loop argument is deprecated since Python 3.8, and scheduled for removal in Python 3.10.' The ecosystem needs more time to catch up here. Broken packages are for example aiohttp, argh and by extension alot of other packages.
mweinelt
changed the title
ofborg
bot
added
10.rebuild-darwin-stdenv
|
We might be able to apply python/cpython@c967bd5 instead of reverting. |
|
Applied the patch. Results are as follows:
Still probably best to go with the revert. |
|
Merging so I can continue with #141037. |
|
A downside of this revert is that this patch is not included (the first release containing it is Python 3.9.7). Which means |
|
@bergkvist PTAL #146477 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This reverts commit d003f75.
Causes an unnecessary amount of breakages due to a DeprecationWarning
regarding the loop argument in asyncio, that is going to be deprecrated
in Python 3.10.
The ecosystem needs more time to catch up here. Broken packages are for
example aiohttp, argh and by extension alot of other packages.
aio-libs/aiohttp#6066
neithere/argh#148
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)