Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CuboCore.packages: added #142380

Merged
merged 1 commit into from
Nov 4, 2021
Merged

Conversation

dan4ik605743
Copy link
Member

@dan4ik605743 dan4ik605743 commented Oct 20, 2021

Motivation for this change
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Copy link
Member Author

@dan4ik605743 dan4ik605743 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything works fine.
image
image

@dan4ik605743 dan4ik605743 mentioned this pull request Oct 20, 2021
12 tasks
@ofborg ofborg bot added 8.has: clean-up 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100 labels Oct 20, 2021
@dan4ik605743 dan4ik605743 mentioned this pull request Oct 28, 2021
12 tasks
@dan4ik605743
Copy link
Member Author

@SuperSandro2000 Everything is ready and great here all build, just need your push.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).

Result of nixpkgs-review pr 142380 run on x86_64-linux 1

22 packages built:
  • CuboCore.coreaction
  • CuboCore.corearchiver
  • CuboCore.corefm
  • CuboCore.coregarage
  • CuboCore.corehunt
  • CuboCore.coreimage
  • CuboCore.coreinfo
  • CuboCore.corekeyboard
  • CuboCore.corepad
  • CuboCore.corepaint
  • CuboCore.corepdf
  • CuboCore.corepins
  • CuboCore.corerenamer
  • CuboCore.coreshot
  • CuboCore.corestats
  • CuboCore.corestuff
  • CuboCore.coreterminal
  • CuboCore.coretime
  • CuboCore.coretoppings
  • CuboCore.coreuniverse
  • CuboCore.libcprime
  • CuboCore.libcsys

@SuperSandro2000 SuperSandro2000 merged commit cfefcfc into NixOS:master Nov 4, 2021
@dan4ik605743
Copy link
Member Author

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).

Result of nixpkgs-review pr 142380 run on x86_64-linux 1

22 packages built:

ok

@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2021

Backport failed for release-21.05, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin release-21.05
git worktree add -d .worktree/backport-142380-to-release-21.05 origin/release-21.05
cd .worktree/backport-142380-to-release-21.05
git checkout -b backport-142380-to-release-21.05
ancref=$(git merge-base 3ef1d2a9602c18f8742e1fb63d5ae9867092e3d6 c33e3917126e8237a9b7a1894ad8b081383db621)
git cherry-pick -x $ancref..c33e3917126e8237a9b7a1894ad8b081383db621

@dan4ik605743
Copy link
Member Author

I will make backporting when my first PR will be examined in 21.05 (#144643), and then I'm not there in the number of Maintainers not recorded, you need to be push, then I will make backporting.

@SuperSandro2000
Copy link
Member

Please create the PR manually and cherry pick the relevant commit.

@dan4ik605743
Copy link
Member Author

Please create the PR manually and cherry pick the relevant commit.

I told me you need my first PR Push, because there is Maintainer-List there.

@dan4ik605743
Copy link
Member Author

dan4ik605743 commented Nov 5, 2021

@SuperSandro2000 check my pr #144643,and I will create immediately on this backport.

@SuperSandro2000
Copy link
Member

The maintainer addition needs first to be in master and then it can be cherry-picked by anyone into a backport PR.

I usually don't merge backports because I am always on unstable on my personal machine and don't know how the state of stable is and if certain required features are already there.

@dan4ik605743
Copy link
Member Author

The maintainer addition needs first to be in master and then it can be cherry-picked by anyone into a backport PR.

I usually don't merge backports because I am always on unstable on my personal machine and don't know how the state of stable is and if certain required features are already there.

Well, well, I still created pr, everything is correct there like. Let's wait like push and I will create on this backport.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: clean-up 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants