-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CuboCore.packages: added #142380
CuboCore.packages: added #142380
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SuperSandro2000 Everything is ready and great here all build, just need your push. |
This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch). Result of 22 packages built:
|
ok |
Backport failed for Please cherry-pick the changes locally. git fetch origin release-21.05
git worktree add -d .worktree/backport-142380-to-release-21.05 origin/release-21.05
cd .worktree/backport-142380-to-release-21.05
git checkout -b backport-142380-to-release-21.05
ancref=$(git merge-base 3ef1d2a9602c18f8742e1fb63d5ae9867092e3d6 c33e3917126e8237a9b7a1894ad8b081383db621)
git cherry-pick -x $ancref..c33e3917126e8237a9b7a1894ad8b081383db621 |
I will make backporting when my first PR will be examined in 21.05 (#144643), and then I'm not there in the number of Maintainers not recorded, you need to be push, then I will make backporting. |
Please create the PR manually and cherry pick the relevant commit. |
I told me you need my first PR Push, because there is Maintainer-List there. |
@SuperSandro2000 check my pr #144643,and I will create immediately on this backport. |
The maintainer addition needs first to be in master and then it can be cherry-picked by anyone into a backport PR. I usually don't merge backports because I am always on unstable on my personal machine and don't know how the state of stable is and if certain required features are already there. |
Well, well, I still created pr, everything is correct there like. Let's wait like push and I will create on this backport. |
Motivation for this change
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)