smokeping service improvements #144127
Merged
smokeping service improvements #144127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bash wrapper process served no purpose, and systemd directly controlling the processes is more reliable / more responsive to systemctl commands.
github-actions
bot
added
6.topic: nixos
nh2
force-pushed
the
smokeping-service-improvements
branch
from
5e1b0d5 to
d3e0911
Compare
github-actions
bot
added
8.has: changelog
8.has: documentation
ofborg
bot
added
10.rebuild-darwin: 0
erictapen
reviewed
Nov 1, 2021
OK, done! |
nh2
force-pushed
the
smokeping-service-improvements
branch
from
b3a68ba to
efaa7c3
Compare
fadenb
approved these changes
Nov 1, 2021
erictapen
approved these changes
Nov 1, 2021
Allows setting smokeping to not listen on the public Internet.
This avoids a common problem: Until now, port forwarding to multiple hosts running smokeping did not work; they all show the data of the first smokeping instance. That ws because the image URLs generated by smokeping are absolute (`imgurl` setting). Consequently, if you ran ssh node-1 -L 8081:localhost:8081 ssh node-2 -L 8081:localhost:8082 ssh node-3 -L 8081:localhost:8083 and try to open http://localhost:8081, http://localhost:8082 and http://localhost:8083, they all would show the images of node-1! Using a relative `imgurl` fixes that. As per smokeping docs on `imgurl`: > Either an absolute URL to the `imgcache` directory or one relative to the > directory where you keep the SmokePing cgi.
Details on NixOS/nixops#1063 (comment). `partOf` makes that if `smokeping.service` is stopped, `thttpd.service` will be stopped as well. (But not that `thttpd` will be started when `smokeping` is started). Once `thttpd.service` is stopped that way, `Restart = always` will not apply. When the smokeping config options are changed, NixOS's `switch-configuration.pl` will stop `smokeping` (whit shuts down thttpd due to `partOf`), and then restart smokeping; but this does not start thttpd. As a result, thttpd will be off after changing the config, which isn't desired. This commit fixes it by removing the `partOf`, which makes `Restart` work as expected.
This makes switch-configuration fail if something is wrong with it, which is desired especially for NixOps deployments.
In general, NixOS services are configured such that by default they are not exposed to the Internet for security, see NixOS#100192.
nh2
force-pushed
the
smokeping-service-improvements
branch
from
efaa7c3 to
a65e7f0
Compare
Ah, I left an unintentional Beyond that, the commits are already self-contained, that is, they work independently of each other, so that if one makes a problem in the future, it can be easily reverted. |
|
Mh yeah, makes sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Upstreaming here multiple improvements to the
smokepingservice that we use in our production setup.Please see the commit messages for the individual motivations.
Things done
CC maintainer: @erictapen
CC recent contributors: @trofi @primeos @aanderse @fadenb @ixmatus @cransom