Package the (Pop!_OS) COSMIC Desktop Environment #144411

Enzime · 2021-11-03T10:30:55Z

Motivation for this change

Currently not all the packages work on GNOME 41 so I've based this off 21.05 which has GNOME 40.

This is a combination of #104160 and #102150 and closes #92769.

Some inspiration from https://gitlab.manjaro.org/packages/community/gnome/cosmic :)

Things done

Enzime · 2021-11-03T10:49:59Z

@ofborg eval

pkgs/desktops/gnome/extensions/pop-shell/default.nix

pkgs/desktops/gnome/extensions/pop-cosmic/default.nix

pkgs/desktops/gnome/extensions/cosmic-workspaces/default.nix

pkgs/desktops/gnome/extensions/cosmic-dock/default.nix

pkgs/desktops/gnome/core/pop-desktop-widget/default.nix

SuperSandro2000 · 2021-11-03T12:51:24Z

pkgs/desktops/gnome/core/pop-desktop-widget/default.nix

+    sha256 = "sha256-QBQBtBSj+J87yAQhYMOrJTUCee3ebJhVc4Y/7EyBDes=";
+  };
+
+  cargoDeps = rustPlatform.fetchCargoTarball {


Why are you not using the rustPlatform mkDerivation?

This is because pop-desktop-widget uses a Makefile execute Cargo

That most likely won't work with nix and we need to replicate that in the right rustPlaform function.

We have plenty of packages that use Make or Ninja to run cargo, and they work fine. Is there a specific problem you've noticed here?

SuperSandro2000 · 2021-11-03T12:51:50Z

pkgs/desktops/gnome/core/pop-control-center/default.nix

+    # "${patchDir}/pop/pop-allow-sound-above-100.patch"
+    "${patchDir}/pop/pop-mouse-accel.patch"
+    "${patchDir}/pop/pop-shop.patch"
+    # "${patchDir}/pop/pop-upgrade.patch"
+    # "${patchDir}/pop/pop-hidpi.patch"
+    # "${patchDir}/pop/system76-firmware.patch"
+    "${patchDir}/pop/pop-alert-sound.patch"
+    "${patchDir}/pop/remove-diagnostics.patch"
+    # "${patchDir}/pop/gsettings-desktop-schemas-version.patch"


Suggested change

# "${patchDir}/pop/pop-allow-sound-above-100.patch"

"${patchDir}/pop/pop-mouse-accel.patch"

"${patchDir}/pop/pop-shop.patch"

# "${patchDir}/pop/pop-upgrade.patch"

# "${patchDir}/pop/pop-hidpi.patch"

# "${patchDir}/pop/system76-firmware.patch"

"${patchDir}/pop/pop-alert-sound.patch"

"${patchDir}/pop/remove-diagnostics.patch"

# "${patchDir}/pop/gsettings-desktop-schemas-version.patch"

"${patchDir}/pop/pop-mouse-accel.patch"

"${patchDir}/pop/pop-shop.patch"

"${patchDir}/pop/pop-alert-sound.patch"

"${patchDir}/pop/remove-diagnostics.patch"

SuperSandro2000 · 2021-11-03T12:52:48Z

Currently not all the packages work on GNOME 41 so I've based this off 21.05 which has GNOME 40.

That has one problem: New package should first appear to master and then be backported. Also support for 21.05 will be ended soon.

Enzime · 2021-11-09T22:19:57Z

Should I change my branch to master then and mark this PR for backporting to 21.05?

pkgs/desktops/gnome/core/pop-desktop-widget/default.nix

alyssais · 2021-11-10T12:49:20Z

Should I change my branch to master then and mark this PR for backporting to 21.05?

Yes, although 21.05 only has a month and a half of support left, so aiming to get this into 21.05 (as opposed to 21.11) might be a bit optimistic.

New packages that don't work on master aren't usually accepted, even if they'd work on stable, but let's keep going for now and hope that upstream can make it work with GNOME 41 soon while we're working out other bits of this PR.

Enzime · 2021-12-12T08:24:19Z

This might be a problem with my configuration, but pop-launcher doesn't seem to work properly (using this PR)
Kooha-12-12-2021-13-47-33.mov

Yeah, I never got pop-launcher working, not too sure what's wrong, I'll have to do more investigation another time

infinisil · 2022-02-28T23:18:48Z

I believe this was fully implemented with the merge of #147542. Feel free to reopen/comment if that's not the case!

infinisil · 2022-02-28T23:19:56Z

Actually, @Enzime pushed new commits to this PR after the merge of the above one, so I'm really not sure

Enzime · 2022-03-01T00:08:32Z

That PR only added the pop-shell package whereas this one includes a couple more packages for the COSMIC desktop environment

sandangel · 2022-05-23T07:11:01Z

hi, may I ask for the status of this PR? I'm using the pop-shell package but pop-shortcuts and pop-launcher does not work. In this PR could we include the gsettings schema? I tried to add the schema so we I configure in dconf but it didn't work.

    extraGSettingsOverridePackages = [
      pkgs.gsettings-desktop-schemas
      pkgs.gnome.gnome-shell
      pkgs.gnomeExtensions.pop-shell
    ];

Enzime · 2022-05-24T00:34:14Z

@sandangel As I'm no longer interested in working on this PR, I'll close the PR now. For anyone interested in packaging COSMIC, feel free to take any of the code in my branch.

I suspect the easiest way to get pop-launcher working would be to run Pop_OS! and investigate what's missing on the NixOS side.

zoedsoupe · 2022-06-14T23:56:08Z

I would like to continue packaging COSMIC. Although I can't right now. As soon as I have time I'll continue if anyone else start before me

nurelin · 2022-08-28T12:24:12Z

Hello,

I have updated the PR on my own branch.

Everything mostly works except for the dock.

Sadly, I will not push further because this DE has the same problem as GNOME
with regards to workspaces and multiple screens.

If anyone wants to try it, I used this configuration:

  # nixos conf
  
  environment.systemPackages = with pkgs; [
      pop-desktop-widget
      pop-control-center
      pop-launcher
      pop-shell-shortcuts
    ];

  services.xserver = {
    enable = true;
    displayManager.gdm.enable = true;
    displayManager.gdm.wayland = true;
    desktopManager.gnome.enable = true;
  };
  
  gnome.core-utilities.enable = true;

  # HomeManager conf

  home.packages = with pkgs; [
    gnome.nautilus
    gnome.gnome-shell-extensions
    gnomeExtensions.appindicator
    gnomeExtensions.pop-shell
    gnomeExtensions.cosmic-dock
    gnomeExtensions.cosmic-workspaces
    gnomeExtensions.pop-cosmic
  ];


    dconf = {
    enable = true;
    settings = {
      "org/gnome/shell" = {
        disable-user-extensions = false;
        enabled-extensions = [
          # cosmic-dock needs dash-to-dock
          "dash-to-dock@micxgx.gmail.com"
          #"cosmic-dock@system76.com"

          "native-window-placement@gnome-shell-extensions.gcampax.github.com"

          #"user-theme@gnome-shell-extensions.gcampax.github.com"
          #"workspace-indicator@gnome-shell-extensions.gcampax.github.com"
          "appindicatorsupport@rgcjonas.gmail.com"
          "pop-shell@system76.com"
          "cosmic-workspaces@system76.com"
          "pop-cosmic@system76.com"
        ];
      };

      # disable incompatible shortcuts
      "org/gnome/mutter/wayland/keybindings" = {
        # restore the keyboard shortcuts: disable <super>escape
        restore-shortcuts = [];
      };
      "org/gnome/desktop/wm/keybindings" = {
        # hide window: disable <super>h
        minimize = [ "<super>comma" ];
        # switch to workspace left: disable <super>left
        switch-to-workspace-left = [];
        # switch to workspace right: disable <super>right
        switch-to-workspace-right = [];
        # maximize window: disable <super>up
        maximize = [];
        # restore window: disable <super>down
        unmaximize = [];
        # move to monitor up: disable <super><shift>up
        move-to-monitor-up = [];
        # move to monitor down: disable <super><shift>down
        move-to-monitor-down = [];
        # super + direction keys, move window left and right monitors, or up and down workspaces
        # move window one monitor to the left
        move-to-monitor-left = [];
        # move window one workspace down
        move-to-workspace-down = [];
        # move window one workspace up
        move-to-workspace-up = [];
        # move window one monitor to the right
        move-to-monitor-right = [];
        # super + ctrl + direction keys, change workspaces, move focus between monitors
        # move to workspace below
        switch-to-workspace-down = [ "<primary><super>down" "<primary><super>j" ];
        # move to workspace above
        switch-to-workspace-up = [ "<primary><super>up" "<primary><super>k" ];
        # toggle maximization state
        toggle-maximized = [ "<super>m" ];
        # close window
        close = [ "<super>q" "<alt>f4" ];
      };
      "org/gnome/shell/keybindings" = {
        open-application-menu = [];
        # toggle message tray: disable <super>m
        toggle-message-tray = [ "<super>v" ];
        # show the activities overview: disable <super>s
        toggle-overview = [];
      };
      "org/gnome/mutter/keybindings" = {
        # disable tiling to left / right of screen
        toggle-tiled-left = [];
        toggle-tiled-right = [];
      };
      "org/gnome/settings-daemon/plugins/media-keys" = {
        # lock screen
        screensaver = [ "<super>escape" ];
        # home folder
        home = [ "<super>f" ];
        # launch email client
        email = [ "<super>e" ];
        # launch web browser
        www = [ "<super>b" ];
        # launch terminal
        terminal = [ "<super>t" ];
        # rotate video lock
        rotate-video-lock-static = [];
      };
      "org/gnome/mutter" = {
        workspaces-only-on-primary = false;
      };
    };
  };

nyabinary · 2023-10-17T13:04:21Z

If anyone is interested, I have a tracking issue of how close we are to COSMIC support: #259641

github-actions bot added the 6.topic: GNOME GNOME desktop environment and its underlying platform label Nov 3, 2021

Enzime requested a review from a team November 3, 2021 10:34

Enzime changed the base branch from nixos-21.05 to release-21.05 November 3, 2021 10:34

SuperSandro2000 reviewed Nov 3, 2021

View reviewed changes

Enzime force-pushed the cosmic branch from a8c9ff0 to ad88fb3 Compare November 9, 2021 22:16

jtojnar reviewed Nov 9, 2021

View reviewed changes

pkgs/desktops/gnome/core/pop-desktop-widget/default.nix Outdated Show resolved Hide resolved

Enzime force-pushed the cosmic branch from ad88fb3 to 32f55ad Compare November 15, 2021 07:59

genofire mentioned this pull request Nov 26, 2021

gnomeExtensions.pop-shell: init #147542

Merged

13 tasks

Enzime force-pushed the cosmic branch from 32f55ad to a6fad8f Compare December 11, 2021 02:40

Enzime requested review from adisbladis, cdepillabout, edolstra, edwtjo, Ericson2314, FRidh, infinisil, joachifm, maralorn, matthewbauer, Mic92, mmahut, nbp, peti, Profpatsch, RaghavSood and roberth as code owners December 11, 2021 02:40

Enzime force-pushed the cosmic branch from 16d50ff to 60cca42 Compare December 12, 2021 12:26

ofborg bot added 8.has: package (new) 11.by: package-maintainer 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 labels Dec 12, 2021

Enzime force-pushed the cosmic branch from 60cca42 to 6038841 Compare December 12, 2021 13:20

Enzime force-pushed the cosmic branch from 6038841 to ed8e722 Compare December 25, 2021 11:04

Enzime added 7 commits December 25, 2021 22:13

cosmic-dock: init at unstable-2021-11-03

63d1276

cosmic-workspaces: init at unstable-2021-11-03

64d24bd

pop-desktop-widget: init at unstable-2021-11-03

fe87d61

pop-control-center: init at unstable-2021-11-03

1138af3

pop-cosmic: init at unstable-2021-11-03

1d3e078

pop-launcher: init at 1.0.3

69043ba

pop-shell-shortcuts: init at unstable-2021-10-02

23df5f5

Enzime force-pushed the cosmic branch from ed8e722 to 23df5f5 Compare December 25, 2021 11:14

infinisil closed this Feb 28, 2022

Enzime reopened this Mar 1, 2022

ofborg bot added the 2.status: merge conflict label Mar 1, 2022

Enzime closed this May 24, 2022

genofire mentioned this pull request May 26, 2022

Super+/ is broken in pop-shell, because the pop-launcher is missing from our package #174353

Closed

KiaraGrouwstra mentioned this pull request Nov 4, 2022

Package request: (Pop!_OS) COSMIC Epoch Desktop Environment #199563

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Package the (Pop!_OS) COSMIC Desktop Environment #144411

Package the (Pop!_OS) COSMIC Desktop Environment #144411

Enzime commented Nov 3, 2021 •

edited

Loading

Enzime commented Nov 3, 2021

SuperSandro2000 Nov 3, 2021

Enzime Nov 9, 2021

SuperSandro2000 Nov 10, 2021

alyssais Nov 10, 2021

SuperSandro2000 Nov 3, 2021

SuperSandro2000 commented Nov 3, 2021

Enzime commented Nov 9, 2021

alyssais commented Nov 10, 2021

Enzime commented Dec 12, 2021

infinisil commented Feb 28, 2022

infinisil commented Feb 28, 2022

Enzime commented Mar 1, 2022

sandangel commented May 23, 2022 •

edited

Loading

Enzime commented May 24, 2022

zoedsoupe commented Jun 14, 2022

nurelin commented Aug 28, 2022

nyabinary commented Oct 17, 2023

Package the (Pop!_OS) COSMIC Desktop Environment #144411

Package the (Pop!_OS) COSMIC Desktop Environment #144411

Conversation

Enzime commented Nov 3, 2021 • edited Loading

Motivation for this change

Things done

Enzime commented Nov 3, 2021

SuperSandro2000 Nov 3, 2021

Choose a reason for hiding this comment

Enzime Nov 9, 2021

Choose a reason for hiding this comment

SuperSandro2000 Nov 10, 2021

Choose a reason for hiding this comment

alyssais Nov 10, 2021

Choose a reason for hiding this comment

SuperSandro2000 Nov 3, 2021

Choose a reason for hiding this comment

SuperSandro2000 commented Nov 3, 2021

Enzime commented Nov 9, 2021

alyssais commented Nov 10, 2021

Enzime commented Dec 12, 2021

infinisil commented Feb 28, 2022

infinisil commented Feb 28, 2022

Enzime commented Mar 1, 2022

sandangel commented May 23, 2022 • edited Loading

Enzime commented May 24, 2022

zoedsoupe commented Jun 14, 2022

nurelin commented Aug 28, 2022

nyabinary commented Oct 17, 2023

Enzime commented Nov 3, 2021 •

edited

Loading

sandangel commented May 23, 2022 •

edited

Loading