Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libdeflate: register static build as test (ref: #144207) #144438

Merged
merged 3 commits into from
Nov 5, 2021
Merged

libdeflate: register static build as test (ref: #144207) #144438

merged 3 commits into from
Nov 5, 2021

Conversation

KAction
Copy link
Contributor

@KAction KAction commented Nov 3, 2021

Motivation for this change

Fix static build of libdeflate

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@KAction
Copy link
Contributor Author

KAction commented Nov 3, 2021

I know that static build is broken and I did not fix it yet. I want to make sure that with static build as test CI will fail.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Nov 3, 2021
@KAction
Copy link
Contributor Author

KAction commented Nov 3, 2021

Any idea why libdeflate, libdeflate.passthru.tests on x86_64-linux — Failure is marked as "neutral", not as failure?

KAction pushed a commit to KAction/libdeflate that referenced this pull request Nov 4, 2021
Add environment variable to disable building shared library
4b47dd7 
Environment variable DISABLE_SHARED (following convention of --disable-shared
of ./configure script) disables building of shared library and shared lib
symlink. It makes life of downstream maintainer easier when maintaining package
for environment that supports only static libraries.

See NixOS/nixpkgs#144438
@KAction KAction mentioned this pull request Nov 4, 2021
Merged
@KAction
Copy link
Contributor Author

KAction commented Nov 4, 2021

I also added myself as maintainer to get notifications about changes. Do we have concept of "subscribe to particular path in repository"?

@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 501+ 10.rebuild-darwin: 2501-5000 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+ and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Nov 4, 2021
ebiggers pushed a commit to ebiggers/libdeflate that referenced this pull request Nov 4, 2021
@ebiggers
Add environment variable to disable building shared library
ee4d188 
Environment variable DISABLE_SHARED (following convention of --disable-shared
of ./configure script) disables building of shared library and shared lib
symlink. It makes life of downstream maintainer easier when maintaining package
for environment that supports only static libraries.

See NixOS/nixpkgs#144438
Dmitry Bogatov added 2 commits November 5, 2021 05:54
libdeflate: fix static build
cd47157 
Patch build system to make building of shared libraries optional, and
disable it when host system is static.
libdeflate: add myself as maintainer of the package
fd2eefb 
I am not really interested in maintaining package pe-se, but since static
version of it is a dependency of something I care about, I want to subscribe
to all changes that can potentially break it.
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux and removed 10.rebuild-darwin: 501+ 10.rebuild-darwin: 2501-5000 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+ labels Nov 5, 2021
@SuperSandro2000
Copy link
Member

I also added myself as maintainer to get notifications about changes. Do we have concept of "subscribe to particular path in repository"?

Only GitHub Codeowners but I think you need commit permissions for that to work.

SuperSandro2000
SuperSandro2000 reviewed Nov 5, 2021
View reviewed changes
pkgs/development/libraries/libdeflate/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/libdeflate/default.nix Outdated
};
}
} // (if stdenv.hostPlatform.isStatic then staticArgs else { }))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we just throw this onto staging to avoid this hackery?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@KAction KAction changed the base branch from master to staging November 5, 2021 13:18
@KAction
Copy link
Contributor Author

KAction commented Nov 5, 2021

What is the process to get commit bit?

@mkg20001
Copy link
Member

mkg20001 commented Nov 5, 2021

If you're active enough you can apply through this issue #50105

@ofborg ofborg bot added 10.rebuild-darwin: 501+ 10.rebuild-darwin: 2501-5000 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+ and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Nov 5, 2021
@SuperSandro2000 SuperSandro2000 merged commit 4183cad into NixOS:staging Nov 5, 2021
@SuperSandro2000
Copy link
Member

If you're active enough you can apply through this issue 50105

Active is not a real hard requirement. I think the only requirements are that you are a trusted member of the community for a reasonable amount of time and you should use the commit bit somewhat regularly and don't be to inactive.

@KAction KAction deleted the static/libdeflate branch November 5, 2021 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-darwin: 2501-5000 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+ 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KAction @SuperSandro2000 @mkg20001