Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.nassl: 4.0.0 -> 4.0.1 #144638

Merged
merged 1 commit into from
Nov 4, 2021
Merged

python3Packages.nassl: 4.0.0 -> 4.0.1 #144638

merged 1 commit into from
Nov 4, 2021

Conversation

veehaitch
Copy link
Member

Motivation for this change

ZHF: #144627

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@veehaitch veehaitch changed the title pythonPackages.nassl: 4.0.0 -> 4.0.1 python3Packages.nassl: 4.0.0 -> 4.0.1 Nov 4, 2021
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Nov 4, 2021
fabianhjr
fabianhjr approved these changes Nov 4, 2021
View reviewed changes
Copy link
Member

@fabianhjr fabianhjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nix-review on NixOS (linux-x86_64):

4 packages built:
python38Packages.nassl python38Packages.sslyze python39Packages.nassl sslyze

👍

thiagokokada
thiagokokada approved these changes Nov 4, 2021
View reviewed changes
Copy link
Contributor

@thiagokokada thiagokokada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 144638 run on x86_64-linux 1

4 packages built:
  • python38Packages.nassl
  • python38Packages.sslyze
  • python39Packages.nassl
  • sslyze (python39Packages.sslyze)

@thiagokokada thiagokokada merged commit 831f9b6 into NixOS:master Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thiagokokada thiagokokada thiagokokada approved these changes

@fabianhjr fabianhjr fabianhjr approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@veehaitch @fabianhjr @thiagokokada