go_1_17: enable on x86_64-darwin

[r-burns]

Apparently this does not depend on stdenv's macOS SDK at all,
and carries around its own go-specific toolchain. So this works
fine as-is and doesn't need any changes in Nixpkgs to support a
10.13 deployment target.

Motivation for this change

Noticed in #144588 (comment)

If this is valid, it would be nice to have for 21.11 (linking #144627 for visibility)

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 21.11 Release Notes (or backporting 21.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

[bobrik]

Can we also update go = go_1_16 to 1.17 in all-packages.nix then?

[r-burns]

Yes, I think so. Happy to do so here or in a separate PR, whatever's preferred.

[bobrik]

There's also this:

  # go_1_17 has go module changes which may not be portable
  # across different go versions and/or platforms,
  # it also requires >=10.13 stdenv on darwin which
  # is not currently available for x86_64-darwin
  #
  # do not uncomment this without approval from the go CODEOWNERS
  #buildGo117Module = callPackage ../development/go-modules/generic {
  #  go = buildPackages.go_1_17;
  #};

  buildGoModule = buildGo116Module;

Not sure if those non-portable go module changes is something that needs to be addressed.

[r-burns]

AFAIK: the "non-portable module changes" part is the reason we can't just go buildGoModule = buildGo117Module immediately, but is independent from the 10.13 SDK concerns. So I think this PR should remove the SDK 10.13 remark from that comment but otherwise leave it untouched.

[thiagokokada]

Result of nixpkgs-review pr 144644 run on x86_64-darwin 1

1 package built:

• go_1_17

[risicle]

Are we waiting on something here?

[thiagokokada]

Are we waiting on something here?

Maybe someone that knows more about Go to merge?

[r-burns]

I was hoping for an ACK from one of the Go codeowners, but it looks like everyone is ok with this. And this is a small change so it's easy to revert if needed.

[Ma27]

AFAIK: the "non-portable module changes" part is the reason we can't just go buildGoModule = buildGo117Module immediately, but is independent from the 10.13 SDK concerns. So I think this PR should remove the SDK 10.13 remark from that comment but otherwise leave it untouched.

That doesn't mean we can enable buildGo117Module though, right? :)
Anyway, I'll take care of that in the Grafana update PR.

[nixos-discourse]

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/missing-go-1-17-on-x86-64-darwin/15032/3