eztrace: 1-1-7 -> 1.1-11, fix build, switch to fetchFromGitLab, refactor #144645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
legendofmiracles
force-pushed
the
master
branch
from
b7e684c to
23448e8
Compare
ofborg
bot
added
10.rebuild-darwin: 0
risicle
reviewed
Nov 4, 2021
| license = lib.licenses.cecill-b; | ||
| maintainers = with lib.maintainers; [ ]; | ||
| license = licenses.cecill-b; | ||
| maintainers = with maintainers; [ ]; |
There was a problem hiding this comment.
You know what I'm going to suggest...
There was a problem hiding this comment.
That I add myself as a maintainer? I honestly don't know
There was a problem hiding this comment.
If you're interested, yeah, I think it would be good to add yourself as maintainer.
There was a problem hiding this comment.
I'm not. Only doing this because of ZHF 🤷
risicle
approved these changes
Nov 4, 2021
thiagokokada
approved these changes
Nov 5, 2021
There was a problem hiding this comment.
Result of nixpkgs-review pr 144645 run on x86_64-linux 1
1 package built:
- eztrace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
ZHF: #144627
https://hydra.nixos.org/build/157349557
I do realize that release tarballs are preferred over source tarballs of the release - but having to patch the resulting configure script feels unnecessary, when we can generate the makefile and configure script ourselves.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)