-
-
Notifications
You must be signed in to change notification settings - Fork 14.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
anup: fix build on darwin #144685
anup: fix build on darwin #144685
Conversation
Result of 1 package failed to build:
|
Hmm, care to post the log? It works on my machine (TM) |
|
Hmm, IDK then. I tried some rebuilds with |
@siraben do you have the sandbox enabled on this machine? This isn't the first rust package where you've received this mysterious SIGABRT that others can't replicate. Builds and works for me, macos 10.15 |
@risicle I'm on macOS 12.0.1, perhaps that's causing the difference? |
Interesting, could be the reason. I'm also on 10.15 FWIW. |
Yup, that sounds a likely culprit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Result of nixpkgs-review pr 144685
run on x86_64-linux 1
No-op on x86_64-linux
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Result of nixpkgs-review pr 144685
run on x86_64-darwin 1
1 package built:
- anup
Going to merge this since it works for at least some versions of macOS (before it didn't work in no one). Patches to fix the build on macOS 12.0 can always be done in another PR. Also, there is the https://discourse.nixos.org/t/nix-macos-monthly/12330 initiative, that once merged should also improve macOS situation (and maybe even fix this issue automatically?). |
Just adding that this built successfully for me on macOS 12.0.1. |
Motivation for this change
ZHF 21.11 #144627
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)