Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

anup: fix build on darwin #144685

Merged
merged 1 commit into from
Nov 6, 2021
Merged

anup: fix build on darwin #144685

merged 1 commit into from
Nov 6, 2021

Conversation

r-burns
Copy link
Contributor

@r-burns r-burns commented Nov 5, 2021

Motivation for this change

ZHF 21.11 #144627

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Nov 5, 2021
@ofborg ofborg bot requested a review from natto1784 November 5, 2021 01:33
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Nov 5, 2021
@siraben
Copy link
Member

siraben commented Nov 5, 2021

Result of nixpkgs-review pr 144685 run on x86_64-darwin 1

1 package failed to build:
  • anup

@r-burns
Copy link
Contributor Author

r-burns commented Nov 5, 2021

Hmm, care to post the log? It works on my machine (TM)

@siraben
Copy link
Member

siraben commented Nov 5, 2021

$ nix log /nix/store/5sphysf2vj5xc79cd64cdnsk0qb6sb0j-anup-0.4.0.drv | ix
http://ix.io/3E48

@r-burns
Copy link
Contributor Author

r-burns commented Nov 5, 2021

Hmm, IDK then. I tried some rebuilds with --check and they are reliable for me.

@risicle
Copy link
Contributor

risicle commented Nov 5, 2021

@siraben do you have the sandbox enabled on this machine? This isn't the first rust package where you've received this mysterious SIGABRT that others can't replicate.

Builds and works for me, macos 10.15

@siraben
Copy link
Member

siraben commented Nov 5, 2021

@risicle I'm on macOS 12.0.1, perhaps that's causing the difference?

@r-burns
Copy link
Contributor Author

r-burns commented Nov 5, 2021

Interesting, could be the reason. I'm also on 10.15 FWIW.

@risicle
Copy link
Contributor

risicle commented Nov 6, 2021

Yup, that sounds a likely culprit

Copy link
Contributor

@thiagokokada thiagokokada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 144685 run on x86_64-linux 1

No-op on x86_64-linux.

Copy link
Contributor

@thiagokokada thiagokokada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 144685 run on x86_64-darwin 1

1 package built:
  • anup

@thiagokokada
Copy link
Contributor

Going to merge this since it works for at least some versions of macOS (before it didn't work in no one).

Patches to fix the build on macOS 12.0 can always be done in another PR.

Also, there is the https://discourse.nixos.org/t/nix-macos-monthly/12330 initiative, that once merged should also improve macOS situation (and maybe even fix this issue automatically?).

@thiagokokada thiagokokada merged commit 4217614 into NixOS:master Nov 6, 2021
@r-burns r-burns deleted the anup branch November 6, 2021 01:21
@thiagokokada
Copy link
Contributor

@risicle I'm on macOS 12.0.1, perhaps that's causing the difference?

BTW, probably also related: #126411

@flurie
Copy link
Contributor

flurie commented Nov 11, 2021

Just adding that this built successfully for me on macOS 12.0.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants