Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perlPackages.XMLLibXML: fix build on darwin #144686

Merged
merged 1 commit into from
Nov 5, 2021
Merged

perlPackages.XMLLibXML: fix build on darwin #144686

merged 1 commit into from
Nov 5, 2021

Conversation

r-burns
Copy link
Contributor

@r-burns r-burns commented Nov 5, 2021

Motivation for this change

ZHF 21.11 #144627

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 11-100 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Nov 5, 2021
thiagokokada
thiagokokada reviewed Nov 5, 2021
View reviewed changes
Copy link
Contributor

@thiagokokada thiagokokada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 144686 run on x86_64-linux 1

No-op on x86_64-linux.

thiagokokada
thiagokokada reviewed Nov 5, 2021
View reviewed changes
Copy link
Contributor

@thiagokokada thiagokokada left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 144686 run on x86_64-darwin 1

1 package marked as broken and skipped:
  • yosys-bluespec
2 packages failed to build:
  • perl532Packages.NetAmazonS3
  • perl534Packages.NetAmazonS3
20 packages built:
  • biber
  • get_iplayer
  • manim
  • perl532Packages.AnyEventRabbitMQ
  • perl532Packages.LaTeXML
  • perl532Packages.NetAMQP
  • perl532Packages.TestXPath
  • perl532Packages.XMLLibXML
  • perl532Packages.XMLLibXMLSimple
  • perl532Packages.XMLLibXSLT
  • perl534Packages.AnyEventRabbitMQ
  • perl534Packages.LaTeXML
  • perl534Packages.NetAMQP
  • perl534Packages.TestXPath
  • perl534Packages.XMLLibXML
  • perl534Packages.XMLLibXMLSimple
  • perl534Packages.XMLLibXSLT
  • sympa
  • tectonic
  • texlive.combined.scheme-full

@thiagokokada
Copy link
Contributor

thiagokokada commented Nov 5, 2021 •
edited
Loading

NetAmazonS3 seems to be also broken on master for x86_64-darwin, so I think it can be fixed in a separate PR.

@thiagokokada thiagokokada merged commit df56e76 into NixOS:master Nov 5, 2021
@r-burns r-burns deleted the xmllibxml branch November 5, 2021 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thiagokokada thiagokokada thiagokokada left review comments

@stigtsp stigtsp Awaiting requested review from stigtsp

@zakame zakame Awaiting requested review from zakame

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 11-100 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@r-burns @thiagokokada