Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.sanic: disable failing tests on aarch64-linux #145022

Merged
merged 1 commit into from
Nov 14, 2021
Merged

python3Packages.sanic: disable failing tests on aarch64-linux #145022

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions pkgs/development/python-modules/sanic/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
, buildPythonPackage
, doCheck ? true
, fetchFromGitHub
, fetchpatch
, gunicorn
, httptools
, multidict
Expand Down Expand Up @@ -68,8 +67,8 @@ buildPythonPackage rec {
inherit doCheck;

preCheck = ''
# Some tests depends on executables on PATH
PATH="$out/bin:${gunicorn}/bin:$PATH"
# Some tests depends on sanic on PATH
PATH="$out/bin:$PATH"
Comment on lines +70 to +71
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My mistake on the previous PR. Gunicorn is already on checkInputs so it should be already available on PATH.

It is just sanic itself that isn't.

'';

disabledTests = [
Expand All @@ -87,6 +86,16 @@ buildPythonPackage rec {
] ++ lib.optionals stdenv.isDarwin [
# https://github.com/sanic-org/sanic/issues/2298
"test_no_exceptions_when_cancel_pending_request"
] ++ lib.optionals (stdenv.hostPlatform.system == "aarch64-linux") [
# These appear to be very sensitive to output of commands
# Output is different on aarch64
"test_server_run"
"test_host_port"
"test_num_workers"
"test_access_logs"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what are the underlying errors. I feel like a lot of these shouldn't be specific to aarch64

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://hydra.nixos.org/build/157553084/nixlog/1

I think at least some of them are related to timing errors, maybe because aarch64 is slower than x86_64 🤔 (I don't know which machines are Hydra running for aarch64).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you mind saying a long the lines of, "these appear to be very sensitive to output of commands. output is different on aarch64"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jonringer Any other issue? Can we get this merged?

"test_version"
# Failing for a different reason than Darwin
"test_no_exceptions_when_cancel_pending_request"
];

# avoid usage of nixpkgs-review in darwin since tests will compete usage
Expand Down