Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Squeak VM with OpenSmalltalk VM #147478

Closed
wants to merge 2 commits into from
Closed

Replace Squeak VM with OpenSmalltalk VM #147478

wants to merge 2 commits into from

Conversation

ehmry
Copy link
Contributor

@ehmry ehmry commented Nov 26, 2021 •
edited
Loading

Motivation for this change

This is the OpenSmalltalk (a.k.a. the Cog VM) virtual machine for Squeak. It replaces the "classic Squeak VM".

This is a patched binary job, the OpenSmalltalk build system tries to download, configure, and build its own dependencies.

Our Squeak maintainer retired in 2018 (0f84673) and I am willing to take this over.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 8.has: clean-up 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Nov 26, 2021
ehmry added 2 commits November 30, 2021 12:55
@ehmry
opensmalltalk-vm-squeak: init at 5.0-202003021730
2dd1d8d 
This is the OpenSmalltalk (a.k.a. the Cog VM) virtual machine for
Squeak. It replaces the "classic" Squeak VM.
@ehmry
Replace squeak with opensmalltalk-vm-squeak
0703338
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog 8.has: documentation This PR adds or changes documentation labels Nov 30, 2021
@ehmry ehmry mentioned this pull request Nov 30, 2021
Closed
@vvs-
Copy link

vvs- commented Nov 30, 2021

Is it related to #133310 ?

@ehmry
Copy link
Contributor Author

ehmry commented Dec 1, 2021

Yes, #133310 is the better PR.

@ehmry ehmry closed this Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog 8.has: clean-up 8.has: documentation This PR adds or changes documentation 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ehmry @vvs- @SuperSandro2000