Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

llvmPackages_13.libcxx: require gcc >=10 on gcc platforms #147543

Merged
merged 1 commit into from
Dec 3, 2021

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Nov 26, 2021

Motivation for this change

ZHF: #144627 @NixOS/nixos-release-managers

Specifically aarch64-linux is targeted here. As of version 13 libcxx does not build on gcc9: https://www.mail-archive.com/llvm-bugs@lists.llvm.org/msg53136.html

This is probably not the neatest way of doing this, mostly because it disobeys the stdenv that is passed in to the metapackage, instead sourcing it from pkgs in this case.

Most of the alternatives I could see though looked just about as bad. One possibility would be build all of llvmPackages_13 with gcc10, which could be done with a neater injection from all-packages.nix. But if a platform has stuck with gcc9, I'm assuming the issues with 10 are severe enough to not want to build an entire toolchain with it.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

specifically aarch64. as of version 13 libcxx does not build on gcc9.
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Nov 26, 2021
@risicle risicle marked this pull request as ready for review November 26, 2021 22:58
@7c6f434c
Copy link
Member

7c6f434c commented Dec 2, 2021

Seems sensible.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2021

Successfully created backport PR #148460 for release-21.11.

@rrbutani rrbutani added the 6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related label May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants