llvmPackages_13.libcxx: require gcc >=10 on gcc platforms #147543
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
ZHF: #144627 @NixOS/nixos-release-managers
Specifically aarch64-linux is targeted here. As of version 13
libcxx
does not build on gcc9: https://www.mail-archive.com/llvm-bugs@lists.llvm.org/msg53136.htmlThis is probably not the neatest way of doing this, mostly because it disobeys the
stdenv
that is passed in to the metapackage, instead sourcing it frompkgs
in this case.Most of the alternatives I could see though looked just about as bad. One possibility would be build all of
llvmPackages_13
with gcc10, which could be done with a neater injection fromall-packages.nix
. But if a platform has stuck with gcc9, I'm assuming the issues with 10 are severe enough to not want to build an entire toolchain with it.Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes