Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

netatalk: fix build #147761

Merged
merged 1 commit into from
Nov 28, 2021
Merged

netatalk: fix build #147761

merged 1 commit into from
Nov 28, 2021

Conversation

arkivm
Copy link
Contributor

@arkivm arkivm commented Nov 28, 2021

Motivation for this change

https://hydra.nixos.org/build/159209379
ZHF: #144627

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@legendofmiracles
Copy link
Contributor

Should be back ported to 21.11

@ofborg ofborg bot requested a review from jcumming November 28, 2021 21:38
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Nov 28, 2021
risicle
risicle approved these changes Nov 28, 2021
View reviewed changes
Copy link
Contributor

@risicle risicle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nixpkgs-review happy, nixos x86_64 & aarch64 (emulated)

@risicle risicle merged commit f4a5fb6 into NixOS:master Nov 28, 2021
@github-actions github-actions bot mentioned this pull request Nov 28, 2021
Merged
1 task
@github-actions
Copy link
Contributor

Successfully created backport PR #147781 for release-21.11.

@arkivm arkivm deleted the fix-netatalk branch November 29, 2021 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@legendofmiracles legendofmiracles legendofmiracles left review comments

@risicle risicle risicle approved these changes

@jcumming jcumming Awaiting requested review from jcumming

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arkivm @legendofmiracles @risicle