Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport release-21.11] umap-learn: fix build #147770

Closed

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Nov 28, 2021

Bot-based backport to release-21.11, triggered by a label in #147662.

  • Before merging, ensure that this backport complies with the Criteria for Backporting.
    • Even as a non-commiter, if you find that it does not comply, leave a comment.

(cherry picked from commit 95312f5)
@risicle
Copy link
Contributor

risicle commented Nov 28, 2021

ZHF #144627

@risicle
Copy link
Contributor

risicle commented Nov 28, 2021

Hold on, umap-learn is already successfully building on 21.11: https://hydra.nixos.org/eval/1726172?filter=umap-learn&compare=1725962&full=

@veprbl
Copy link
Member

veprbl commented Nov 29, 2021

It was broken in update to tensorflow 2.7.0, which is not in 21.11. I assume, that previously tensorflow would ship a copy of keras, and just "depends" on it. In nixpkgs, currently, we don't have keras in tensorflow.propagatedBuildInputs, so it needs to be added explicitly as needed.

@veprbl veprbl closed this Nov 29, 2021
@Artturin Artturin deleted the backport-147662-to-release-21.11 branch November 29, 2021 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants