Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libxc: fix darwin build #148073

Merged
merged 1 commit into from
Dec 2, 2021
Merged

libxc: fix darwin build #148073

merged 1 commit into from
Dec 2, 2021

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Nov 30, 2021 •
edited
Loading

Motivation for this change

ZHF: #144627 @NixOS/nixos-release-managers

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@risicle risicle marked this pull request as ready for review November 30, 2021 22:23
@r-burns
Copy link
Contributor

r-burns commented Nov 30, 2021

I think the cmake flag -DCMAKE_SKIP_BUILD_RPATH=OFF is preferable, if it works here.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Nov 30, 2021
@ofborg ofborg bot requested a review from markuskowa November 30, 2021 23:33
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Nov 30, 2021
@ofborg ofborg bot added 10.rebuild-linux: 1-10 and removed 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Dec 1, 2021
@markuskowa markuskowa merged commit e04e9a4 into NixOS:master Dec 2, 2021
@github-actions github-actions bot mentioned this pull request Dec 2, 2021
Merged
1 task
@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2021

Successfully created backport PR #148229 for release-21.11.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markuskowa markuskowa Awaiting requested review from markuskowa

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@risicle @r-burns @markuskowa