-
-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Julia changes related to the release of 1.7.0 #148170
Conversation
@@ -62,19 +61,11 @@ stdenv.mkDerivation rec { | |||
''; | |||
|
|||
meta = { | |||
description = "High-level, high-performance dynamic language for technical computing"; | |||
description = "High-level, high-performance dynamic language for technical computing."; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://nixos.org/manual/nixpkgs/stable/#var-meta-description
Don’t include a period at the end.
On Wed 01 Dec 2021, 7c6f434c wrote:
@7c6f434c commented on this pull request.
> @@ -62,19 +61,11 @@ stdenv.mkDerivation rec {
'';
meta = {
- description = "High-level, high-performance dynamic language for technical computing";
+ description = "High-level, high-performance dynamic language for technical computing.";
https://nixos.org/manual/nixpkgs/stable/#var-meta-description
> Don’t include a period at the end.
Well spotted, correcting for both `julia_16-bin` and `julia_17-bin`.
|
In line with the upstream announcement: https://discourse.julialang.org/t/julia-v1-7-0-has-been-released-and-v1-6-is-now-lts/72336
No longer supported upstream: https://discourse.julialang.org/t/julia-v1-7-0-has-been-released-and-v1-6-is-now-lts/72336
Thank you @7c6f434c for spotting these.
I wonder what are the chances that aarch64-linux will just work (say, at least build on ofborg) |
On Wed 01 Dec 2021, 7c6f434c wrote:
I wonder what are the chances that aarch64-linux will just work (say, at least build on ofborg)
Nearly 100% I would say, but I would either need to take the time to get my PINE64 up and running or have my PR merged for access to the community build box [1] to be able to debug. Still, I am a bit strapped for time at the moment, so I would greatly appreciate if this could be handled separately from this PR.
[1]: NixOS/aarch64-build-box#109
|
Well, if there is need to debug beyond checking the build outcome on OfBorg, it would not be «just» |
Motivation for this change
Julia 1.7.0 is the new stable and 1.6.4 the new LTS, with support for 1.0.5 being dropped. Reflect this in Nixpkgs.
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes