retroarch: 1.9.13.2 -> 1.9.14; libretro: unstable-2021-11-22 -> unstable-2021-12-06 #149114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thiagokokada
commented
Dec 6, 2021
Comment on lines
-547
to
-553
| patches = [ | ||
| (fetchpatch { | ||
| name = "fix_mame_build_on_make-4.3.patch"; | ||
| url = "https://github.com/libretro/mame2016-libretro/commit/5874fae3d124f5e7c8a91634f5473a8eac902e47.patch"; | ||
| sha256 = "061f1lcm72glksf475ikl8w10pnbgqa7049ylw06nikis2qdjlfn"; | ||
| }) | ||
| ]; |
There was a problem hiding this comment.
Merged upstream: libretro/mame2016-libretro#47
|
Result of 89 packages built:
|
ofborg
bot
added
11.by: package-maintainer
|
Tested:
|
|
CC @aanderse |
thiagokokada
commented
Dec 6, 2021
Comment on lines
+809
to
811
| snes9x2005-plus = mkLibRetroCore { | ||
| core = "snes9x2005-plus"; | ||
| src = getCoreSrc "snes9x2005"; | ||
| description = "Optimized port/rewrite of SNES9x 1.43 to Libretro, with Blargg's APU"; | ||
| license = "Non-commercial"; | ||
| makefile = "Makefile"; | ||
| makeFlags = [ "USE_BLARGG_APU=1" ]; | ||
| postBuild = "mv snes9x2005_plus_libretro${stdenv.hostPlatform.extensions.sharedLibrary} snes9x2005_libretro${stdenv.hostPlatform.extensions.sharedLibrary}"; | ||
| }; |
There was a problem hiding this comment.
snes9x2005 with USE_BLARGG_APU results on snes9x2005-plus (that was what we previously called snes9x2005). So this just fixes it, and add a proper snes9x2005 (without the USE_BLARGG_APU set).
| @@ -674,7 +659,6 @@ in | |||
|
|
|||
| pcsx2 = mkLibRetroCore { | |||
| core = "pcsx2"; | |||
| version = "unstable-2021-11-27"; | |||
There was a problem hiding this comment.
No more version for this guy?
There was a problem hiding this comment.
It derivates the version from here: https://github.com/NixOS/nixpkgs/pull/149114/files#diff-86029dc4c3d1ca3e77939271748ead9d43e99e83df50a7d368337b59e64b3b30R58.
The only reason this version was set before because when I introduced this core in PR #147622 I didn't want to bump all other cores.
Also, migrate old MAME cores to build with Python 3 instead of Python 2.
This is actually the old `libretro.snes9x2005` renamed with the proper core name, and the `libretro.snes9x2005` now is build without the Blaarg's APU (same as upstream).
|
Result of 90 packages built:
|
thiagokokada
commented
Dec 6, 2021
Comment on lines
-406
to
-408
| postPatch = '' | ||
| sed -i -e 's:-Wall:-Wall -Wno-format-security:g' src/burner/libretro/Makefile | ||
| ''; |
There was a problem hiding this comment.
Doesn't seem to be needed anymore, build and works fine without it.
thiagokokada
commented
Dec 6, 2021
| preBuild = "cd src/burner/libretro"; | ||
| makeFlags = [ "USE_EXPERIMENTAL_FLAGS=1" ]; |
There was a problem hiding this comment.
This flag seems to be used mostly for optimizations on slow platforms. Seems to enable some "dangerous" optimization flags that are not needed on x86_64 or even aarch64.
There was a problem hiding this comment.
The slow platforms that upstream enable are either a Funkey S or a Classic NES/SNES that should be much slower than any platform we support.
|
Thanks @thiagokokada 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
New release: https://www.libretro.com/index.php/retroarch-1-9-14-release/
Also, migrate old MAME cores to build with Python 3 instead of Python 2 (issue: #148779).
As always, some clean-ups. Sorry for the reviewers.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes