Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sssd: 2.6.0 -> 2.6.1, fix broken build #150508

Merged
merged 2 commits into from
Dec 14, 2021
Merged

sssd: 2.6.0 -> 2.6.1, fix broken build #150508

merged 2 commits into from
Dec 14, 2021

Conversation

illustris
Copy link
Contributor

@illustris illustris commented Dec 13, 2021 •
edited
Loading

python2Packages.ldap fails to build since #149010
This PR drops python2 bindings for sssd.

Motivation for this change
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@illustris
Copy link
Contributor Author 

Link to currently reviewing PR:
https://github.com/NixOS/nixpkgs/pull/150508

2 packages built:
autofs5 sssd

Also relevant to the removal of python2: #148779

@ofborg ofborg bot requested a review from outergod December 13, 2021 08:24
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Dec 13, 2021
@piegamesde piegamesde mentioned this pull request Dec 13, 2021
Closed
@illustris
sssd: 2.6.0 -> 2.6.1, fix broken build
580952d 
python2Packages.ldap fails to build since NixOS#149010
This PR drops python2 bindings for sssd.
@illustris
sssd: link NixOS module tests
434985c
veprbl
veprbl approved these changes Dec 14, 2021
View reviewed changes
Copy link
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@veprbl veprbl merged commit 33967b3 into NixOS:master Dec 14, 2021
@illustris illustris mentioned this pull request Dec 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veprbl veprbl veprbl approved these changes

@outergod outergod Awaiting requested review from outergod

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@illustris @veprbl @SuperSandro2000