Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport release-21.11] commit-formatter: init at 0.2.1 #154170

Merged
merged 1 commit into from
Jan 10, 2022

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jan 9, 2022

Bot-based backport to release-21.11, triggered by a label in #154110.

  • Before merging, ensure that this backport complies with the Criteria for Backporting.
    • Even as a non-commiter, if you find that it does not comply, leave a comment.

Update pkgs/applications/version-management/commit-formatter/default.nix

Co-authored-by: Bobby Rong <rjl931189261@126.com>

Update pkgs/applications/version-management/commit-formatter/default.nix

Co-authored-by: Fabian Affolter <mail@fabian-affolter.ch>

Update pkgs/applications/version-management/commit-formatter/default.nix

Co-authored-by: Bobby Rong <rjl931189261@126.com>
(cherry picked from commit 1ed1e00)
@lovesegfault
Copy link
Member

We don't backport package additions, I don't think.

@lovesegfault lovesegfault deleted the backport-154110-to-release-21.11 branch January 9, 2022 19:14
@bobby285271
Copy link
Member

bobby285271 commented Jan 9, 2022

Any reasons? I think package addition is actually explicitly allowed according to Criteria for Backporting changes and backport should be able to happen at anytime, and we already backported some package additions.

Edit: runs for me.

@bobby285271 bobby285271 restored the backport-154110-to-release-21.11 branch January 9, 2022 23:41
@bobby285271 bobby285271 reopened this Jan 9, 2022
@bobby285271 bobby285271 merged commit 5d3420c into release-21.11 Jan 10, 2022
@bobby285271 bobby285271 deleted the backport-154110-to-release-21.11 branch January 10, 2022 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants