Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grass: fix build on darwin #156828

Merged
merged 1 commit into from
Jan 27, 2022
Merged

grass: fix build on darwin #156828

merged 1 commit into from
Jan 27, 2022

Conversation

willcohen
Copy link
Contributor

Motivation for this change

Building on #156747, working to unblock QGIS dependencies on darwin.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Jan 26, 2022
@willcohen
Copy link
Contributor Author

Result of nixpkgs-review pr 156828 run on x86_64-darwin 1

1 package built:
  • grass

@willcohen
Copy link
Contributor Author

Also mentioning @mpickering as maintainer here

@SuperSandro2000 SuperSandro2000 merged commit 90087b3 into NixOS:master Jan 27, 2022
@willcohen
Copy link
Contributor Author

Many thanks @SuperSandro2000!

@willcohen willcohen deleted the grass-darwin branch January 27, 2022 13:17
@willcohen willcohen mentioned this pull request Feb 2, 2022
Open
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@willcohen @SuperSandro2000