-
-
Notifications
You must be signed in to change notification settings - Fork 14.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixUnstable: pre20220127 -> pre20220207 #158455
Conversation
this breaks |
Result of 1 package failed to build:
1 package built:
|
I did figure out a patch: NickCao@a89e608 , and have being running with it on my hydra for days without problems, still need someone familiar with hydra-eval-jobs to review it. Pinning nix to nixVersions.stable is not a viable fix as restricted evaluation is broken on nix 2.6.0. |
Do note that this also fixes NixOS/nix#6036 |
265b2b8
to
771911a
Compare
@ofborg build hydra-unstable |
I'm not in favor of blocking this indefinitely. as these bugs fixes are critical to our users. If nobody objects the hydra patch, shall we just merge this. |
Let's merge, please submit the patch upstream |
Shall I mark hydra-unstable as broken for now? |
No, I meant let's merge and submit the patch upstream |
It would be better to create a pr in the hydra repo and then fetchpatch and add a comment to the pr |
Currently hydra's policy is to support the stable version of nix, upstream pr has no where to target until hydra have a staging branch for us. |
Oops, that patch was a little bit out dated, I will submit a new one soon. |
Motivation for this change
fixes NixOS/nix#5985
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes