keyd: init at 2.2.5-beta and Keyd module #158793

cidkidnix · 2022-02-09T15:52:41Z

Expands on #158489, and allows for the per-application keyd experiment to work
Also closes #132474.

dit7ya

Thanks for submitting this PR!

Have not built it myself but left some general comments. Also, I am not sure if this belongs to the hardware directory. I don't know have a strong opinion for any other directory though.

dit7ya · 2022-02-11T14:30:15Z

nixos/modules/services/hardware/keyd.nix

+      };
+
+      configuration = mkOption {
+        type = types.lines;


Would be nice to allow a config file path as well.

Not exactly filepath since keyd expects it's configs under /etc/keyd but I've made it possible to have multiple config files in the latest commit

If it needs a directory containing files passed to it rather than a specific file, there still isn't anything wrong with setting this to types.path.

pkgs/tools/inputmethods/keyd/default.nix

dit7ya · 2022-02-11T14:48:20Z

nixos/modules/services/hardware/keyd.nix

+    maintainers = [ "cidkid" ];
+  };
+
+  options = {


Probably worth adding options applicationSpecificMapping.enable and applicationSpecificMapping.config if you are building it with Python (which is not required for the base version). Also, I don't see keyd-application-mapper being called anywhere in the systemd service.

Keyd recommends to use your wm or an autostart to launch keyd-application-mapper, and we can't define it in a declarative way due to the config path being in the users $HOME

You could write a systemd user service (i.e. systemd.user.services.keyd-application-mapper)

There are users created here and now talks of running it as a user service. If it can run as a user service, it definitely doesn't need a hardcoded user.

foolnotion · 2022-03-12T17:07:37Z

I've been using this for over a month and it works great. It would be awesome to see it merged.

nixos/modules/services/hardware/keyd.nix

Sohalt · 2022-04-29T12:30:35Z

nixos/modules/services/hardware/keyd.nix

+        default = {};
+
+        description = ''
+          What the filename should be for configuration files for keyd (Multiple are allowed in keyd)


The description is a little confusing. Also can you add an example?

nixos/modules/services/hardware/keyd.nix

Sohalt · 2022-04-29T12:34:38Z

nixos/modules/services/hardware/keyd.nix

+      configuration = mkOption {
+        type = types.attrsOf (types.submodule ({ config, options, ... }: {
+          options = {
+            text = mkOption {


Do you gain anything by making this a submodule instead of just making it a listOf? The name of the config file is largely irrelevant, isn't it? Also I'd prefer making this a lisfOf path, to have the config in a separate file, but that's just personal preference.

Is there any point to allowing multiple configuration files? That sounds like an implementation detail to me...

Additionally, is there any way we can accept a nix attribute set for the actual configuration?

@dit7ya requested the ability to have multiple config files

But what is the reason for multiple files? @aanderse's point about passing an attrset is also valid.

pkgs/tools/inputmethods/keyd/default.nix

aanderse

Please add changelog entry as contributing document states.

aanderse · 2022-05-11T09:56:11Z

nixos/modules/services/hardware/keyd.nix

+
+  config = mkIf cfg.enable {
+    users.groups.keyd = {
+      gid = 994;


Is seeing a gid necessary?

Not certain, I believe there was a reason before although I can't find it

We have a community rfc stating not to use uid and gid unless explicitly necessary. So see if you can remember or not.

nixos/modules/services/hardware/keyd.nix

aanderse · 2022-05-11T10:03:05Z

nixos/modules/services/hardware/keyd.nix

+      configuration = mkOption {
+        type = types.attrsOf (types.submodule ({ config, options, ... }: {
+          options = {
+            text = mkOption {


Is there any point to allowing multiple configuration files? That sounds like an implementation detail to me...

Additionally, is there any way we can accept a nix attribute set for the actual configuration?

nixos/modules/services/hardware/keyd.nix

SuperSandro2000 · 2022-05-12T12:51:23Z

nixos/modules/services/hardware/keyd.nix

+      };
+    };
+  };
+}


Missing final new line

pkgs/tools/inputmethods/keyd/default.nix

edrex

Overall looks good.

I tested with the changes below and it works for me.

I wish upstream didn't take a hard line about restricting config paths to /etc/keyd (rvaiya/keyd#70); that is rather idiosyncratic. Ah well.

Let's get this merged!

nixos/modules/services/hardware/keyd.nix

pkgs/tools/inputmethods/keyd/default.nix

cidkidnix · 2022-06-22T09:36:00Z

Sorry about the long-wait on this, I've been busy!

nixos/modules/services/hardware/keyd.nix

pkgs/tools/inputmethods/keyd/default.nix

nixos-discourse · 2022-08-16T14:09:01Z

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/how-to-bring-karabiner-elements-to-nixos/21011/7

pdelfino · 2022-08-17T23:40:10Z

Thanks for the work! This PR was mentioned in this discussion on NixOS official Discourse.

cidkidnix · 2022-08-18T01:08:35Z

This isn't closed, just accidentally updated my local nixpkgs tree and forced pushed, oops

cidkidnix · 2022-08-18T01:21:09Z

https://github.com/cidkidnix/nixpkgs/tree/cidkidnix/keyd,
New tree, sorry about that

benide · 2022-08-18T01:39:42Z

You might need to open a new PR if my understanding of how github works is correct.

NixOS/nixpkgs#158793

nixos-discourse · 2023-01-27T07:50:39Z

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/how-to-get-the-service-running-for-keyd/24991/2

github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Feb 9, 2022

ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Feb 9, 2022

cidkidnix changed the title ~~init: keyd 2.2.5-beta and Keyd module~~ keyd: init at 2.2.5-beta and Keyd module Feb 10, 2022

dit7ya suggested changes Feb 11, 2022

View reviewed changes

tgharib mentioned this pull request Apr 17, 2022

keyd: init at 2.2.7-beta #169057

Closed

13 tasks

Sohalt suggested changes Apr 29, 2022

View reviewed changes

ofborg bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label May 9, 2022

aanderse reviewed May 11, 2022

View reviewed changes

SuperSandro2000 reviewed May 12, 2022

View reviewed changes

nixos/modules/services/hardware/keyd.nix Outdated

};

};

};

}

Copy link

Member

SuperSandro2000 May 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing final new line

SuperSandro2000 reviewed May 12, 2022

View reviewed changes

pkgs/tools/inputmethods/keyd/default.nix Outdated Show resolved Hide resolved

SuperSandro2000 reviewed May 12, 2022

View reviewed changes

pkgs/tools/inputmethods/keyd/default.nix Outdated Show resolved Hide resolved

edrex suggested changes Jun 13, 2022

View reviewed changes

SuperSandro2000 reviewed Jun 22, 2022

View reviewed changes

nixos/modules/services/hardware/keyd.nix Outdated Show resolved Hide resolved

SuperSandro2000 reviewed Jun 22, 2022

View reviewed changes

pkgs/tools/inputmethods/keyd/default.nix Outdated Show resolved Hide resolved

SuperSandro2000 reviewed Jun 22, 2022

View reviewed changes

pkgs/tools/inputmethods/keyd/default.nix Outdated Show resolved Hide resolved

dit7ya mentioned this pull request Jul 13, 2022

keyd: init at 2.4.1 #181361

Merged

13 tasks

cidkidnix merged commit bb3b4db into NixOS:master Aug 18, 2022

cidkidnix force-pushed the master branch from c37c305 to bb3b4db Compare August 18, 2022 00:57

edrex added a commit to edrex/nixos-config that referenced this pull request Dec 30, 2022

vendor keyd module from PR

617b588

NixOS/nixpkgs#158793

edrex added a commit to edrex/nixos-config that referenced this pull request Dec 30, 2022

fixups to keyd module

be4eed7

NixOS/nixpkgs#158793

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

keyd: init at 2.2.5-beta and Keyd module #158793

keyd: init at 2.2.5-beta and Keyd module #158793

cidkidnix commented Feb 9, 2022 •

edited

Loading

dit7ya left a comment •

edited

Loading

dit7ya Feb 11, 2022

cidkidnix Feb 13, 2022

peterhoeg Jul 14, 2022

dit7ya Feb 11, 2022

cidkidnix Feb 11, 2022

Sohalt Apr 29, 2022

peterhoeg Jul 14, 2022

foolnotion commented Mar 12, 2022

Sohalt Apr 29, 2022

Sohalt Apr 29, 2022

aanderse May 11, 2022

cidkidnix May 11, 2022

peterhoeg Jul 14, 2022

aanderse left a comment

aanderse May 11, 2022

cidkidnix May 11, 2022

aanderse May 12, 2022 •

edited

Loading

aanderse May 11, 2022

SuperSandro2000 May 12, 2022

edrex left a comment

cidkidnix commented Jun 22, 2022 •

edited

Loading

nixos-discourse commented Aug 16, 2022

pdelfino commented Aug 17, 2022

cidkidnix commented Aug 18, 2022

cidkidnix commented Aug 18, 2022

benide commented Aug 18, 2022

nixos-discourse commented Jan 27, 2023

keyd: init at 2.2.5-beta and Keyd module #158793

keyd: init at 2.2.5-beta and Keyd module #158793

Conversation

cidkidnix commented Feb 9, 2022 • edited Loading

dit7ya left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

foolnotion commented Mar 12, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aanderse left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aanderse May 12, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

edrex left a comment

Choose a reason for hiding this comment

cidkidnix commented Jun 22, 2022 • edited Loading

nixos-discourse commented Aug 16, 2022

pdelfino commented Aug 17, 2022

cidkidnix commented Aug 18, 2022

cidkidnix commented Aug 18, 2022

benide commented Aug 18, 2022

nixos-discourse commented Jan 27, 2023

cidkidnix commented Feb 9, 2022 •

edited

Loading

dit7ya left a comment •

edited

Loading

aanderse May 12, 2022 •

edited

Loading

cidkidnix commented Jun 22, 2022 •

edited

Loading