Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

busybox: add enableAppletSymlinks?true #161007

Merged
merged 1 commit into from Mar 6, 2022
Merged

busybox: add enableAppletSymlinks?true #161007

merged 1 commit into from Mar 6, 2022

Conversation

ghost
Copy link

@ghost ghost commented Feb 20, 2022

... which can be set to false in order to turn off CONFIG_INSTALL_APPLET_SYMLINKS

The default behavior is unchanged. Users can set enableAppletSymlinks=false if they only want the main busybox binary in their profile. This is particularly useful when building pkgsStatic.busybox.

My own personal use case: I run a hybrid debian-nixpkgs system (I'm slowly migrating to nixpkgs). Busybox includes a binary called dpkg which does almost nothing of what dpkg does. I have nix-profile/bin ahead of /usr/bin in my $PATH so I can use the nixpkgs version of things that would cause debian to break if I uninstalled them.

Motivation for this change
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

This commit adds an argument enableAppletSymlinks?true, which can be
set to false in order to turn off CONFIG_INSTALL_APPLET_SYMLINKS by
users if they only want the main busybox binary in their profile.
This is particularly useful when building pkgsStatic.busybox.
@ghost
Copy link
Author

ghost commented Feb 23, 2022

Latest force push adds a commit message, no other changes.

@Artturin
Copy link
Member

Artturin commented Mar 6, 2022

this probably isn't needed because there's already a extraConfig / enableMinimal

@Artturin
Copy link
Member

Artturin commented Mar 6, 2022

changed my mind

@Artturin Artturin merged commit a0820a9 into NixOS:master Mar 6, 2022
@ghost
Copy link
Author

ghost commented Mar 6, 2022

Thank you!

@ghost ghost deleted the busybox-allow-disabling-applet-symlinks branch March 6, 2022 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant