Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add mechanism for handling meta.sourceProvenance attributes #161098

Merged
merged 7 commits into from
May 30, 2022
Merged

add mechanism for handling meta.sourceProvenance attributes #161098

merged 7 commits into from
May 30, 2022

Commits on May 20, 2022

  1. add mechanism for handling meta.sourceProvenance attributes 

    heavily based on patterns used by licenses infrastructure, so may
appear overengineered for its initial level of use
    @risicle
    risicle committed May 20, 2022
    Configuration menu
    Copy the full SHA
    befb95a View commit details
    Browse the repository at this point in the history

  2. add initial meta.sourceProvenance documentation

    @risicle
    risicle committed May 20, 2022
    Configuration menu
    Copy the full SHA
    9287f36 View commit details
    Browse the repository at this point in the history

  3. meta.sourceProvenance documentation: clarify it is unaffected by chan… 

    …ges to meta.license

This commit clarifies that the meaning of the `meta.sourceProvenance`
field is independent of and unaffected by the value of the
`meta.license` field.  This is based on the intent of the RFC author
as expressed here:

  NixOS#161098 (comment)

This clarification is added for two reasons:

1. If in the future there should be some disagreement about what
   `sourceProvenance` to assign to a package, this may help resolve
   the disagreement.  Any interpretation of `sourceProvenance` which
   is influenced by the `meta.license` is clearly an incorrect
   interpretation.

2. If it should turn out that it is impossible to disentangle
   `sourceProvenance` from `meta.license`, this would indicate the
   need for changes to the `sourceProvenance` scheme.  That change
   might be as simple as replacing the sentence added by this commit
   with some other sentence explaining how the two fields influence
   each other.

This commit implements the recommendation made in the paragraph of
this comments which begins with "Please say this explicitly...":

  NixOS#161098 (comment)
    @risicle
    Adam Joseph authored and risicle committed May 20, 2022
    Configuration menu
    Copy the full SHA
    0b3beeb View commit details
    Browse the repository at this point in the history

  4. meta.sourceProvenance: disallow string values 

    strings complicate reasoning about values and may not be needed with `sourceProvenance`

Co-authored-by: Alexander Foremny <aforemny@posteo.de>
    @risicle @aforemny
    risicle and aforemny committed May 20, 2022
    Configuration menu
    Copy the full SHA
    80ce947 View commit details
    Browse the repository at this point in the history

  5. allowNonSourcePredicate: use example of categorical permissivity 

    Co-authored-by: Adam Joseph <54836058+a-m-joseph@users.noreply.github.com>
    @risicle
    risicle and Adam Joseph committed May 20, 2022
    Configuration menu
    Copy the full SHA
    27db166 View commit details
    Browse the repository at this point in the history

  6. meta.sourceProvenance: inline hasSourceProvenance 

    it may be what the license handling code does, but it's confusing and not very useful

Co-authored-by: Adam Joseph <54836058+a-m-joseph@users.noreply.github.com>
    @risicle
    risicle and Adam Joseph committed May 20, 2022
    Configuration menu
    Copy the full SHA
    97bb4aa View commit details
    Browse the repository at this point in the history

  7. lib.sourceTypes: simplify implementation 

    Co-authored-by: Alexander Foremny <aforemny@posteo.de>
    @risicle @aforemny
    risicle and aforemny committed May 20, 2022
    Configuration menu
    Copy the full SHA
    d4c9023 View commit details
    Browse the repository at this point in the history