Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[staging] mypy: 0.931 → 0.941 #165019

Merged
merged 1 commit into from
Mar 21, 2022
Merged

[staging] mypy: 0.931 → 0.941 #165019

merged 1 commit into from
Mar 21, 2022

Conversation

fabianhjr
Copy link
Member

@fabianhjr fabianhjr commented Mar 20, 2022 •
edited
Loading

patch was rebased (solved 1 conflict)

Built and tested on python39Packages (system-wide with nixos-rebuild) and python310Packages (local / home-manager).

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

This was referenced Mar 20, 2022
Merged
Closed
@fabianhjr
Copy link
Member Author

/marvin opt-in
/status needs_reviewer

@marvin-mk2
Copy link

marvin-mk2 bot commented Mar 20, 2022

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@marvin-mk2 marvin-mk2 bot added marvin This PR was reviewed by Marvin, a discontinued bot: https://github.com/timokau/marvin-mk2 needs_reviewer (old Marvin label, do not use) labels Mar 20, 2022
@ofborg ofborg bot requested review from martingms, LnL7 and SuperSandro2000 March 20, 2022 20:54
@marvin-mk2 marvin-mk2 bot added awaiting_reviewer (old Marvin label, do not use) and removed needs_reviewer (old Marvin label, do not use) labels Mar 20, 2022
@fabianhjr
mypy: 0.931 → 0.941
3c0e4f9 
patch was rebased (solved 1 conflict)
@fabianhjr fabianhjr requested a review from ttuegel as a code owner March 20, 2022 21:03
@fabianhjr fabianhjr changed the base branch from master to staging March 20, 2022 21:04
@fabianhjr fabianhjr changed the title mypy: 0.931 → 0.941 [staging] mypy: 0.931 → 0.941 Mar 20, 2022
@fabianhjr fabianhjr removed the request for review from ttuegel March 20, 2022 22:26
@SuperSandro2000 SuperSandro2000 merged commit f04595e into NixOS:staging Mar 21, 2022
@fabianhjr fabianhjr deleted the update-mypy branch March 21, 2022 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@martingms martingms Awaiting requested review from martingms

@LnL7 LnL7 Awaiting requested review from LnL7

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 101-500 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+ awaiting_reviewer (old Marvin label, do not use) marvin This PR was reviewed by Marvin, a discontinued bot: https://github.com/timokau/marvin-mk2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fabianhjr @SuperSandro2000