-
-
Notifications
You must be signed in to change notification settings - Fork 14.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
platforms: use native arch parameters for apple-m1 #166535
Conversation
This should allow clang to better optimise for the only aarch64-darwin CPU µarch Closes NixOS#166401
@Atemu Can you undraft this so reviewers get pinged? It'd be great to land this :) |
This is untested but sure |
Why does ofborg think that this isn't a mass rebuild? |
Perhaps it only checks x86_64-darwin? |
nixpkgs-review reports |
IMO we should wait for this staging cycle to end, and then just let this hit staging and see what happens. I don't think there's another practical way of testing it |
We should also do some benchmarks as µarch optimisations don't necessarily result in a performance improvement. |
We're about to start another |
It's not clear whether this is an improvement yet. We'd have to actually run some benchmarks to get a picture. It might very well cause huge regressions rather than improvements. I also haven't found the time to do any builds yet, so I don't even know whether anything builds with this applied. |
Yeah, this doesn't even build anything. Clang doesn't know about I'm not sure this is worthwhile pursuing but I'll try to build a few benchmarks with the improved but reduced set. I'm also not quite sure whether it makes sense to set arch and cpu differently. Shouldn't these flags go in CPU only? |
I don't plan on pursuing this any further. |
This should allow clang to better optimise for the only aarch64-darwin CPU µarch
Closes #166401
Description of changes
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes