Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qpid-cpp: switch to python3 #169816

Merged
merged 1 commit into from
May 9, 2022
Merged

qpid-cpp: switch to python3 #169816

merged 1 commit into from
May 9, 2022

Conversation

armeenm
Copy link
Contributor

@armeenm armeenm commented Apr 22, 2022

qpid-cpp only supports python2 bindings, so they've been removed. #148779
(Also, the current derivation on master doesn't build; this one does)

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

qpid-cpp only supports python2 bindings, so they've been removed
@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Apr 22, 2022
@ofborg ofborg bot requested a review from cpages April 22, 2022 16:13
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Apr 22, 2022
@davidak
Copy link
Member

davidak commented May 9, 2022

Result of nixpkgs-review pr 169816 run on x86_64-linux 1

1 package built:
  • qpid-cpp

Copy link
Member

@davidak davidak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good

Builds

Simple execution works

@davidak davidak merged commit 2df9665 into NixOS:master May 9, 2022
@armeenm armeenm deleted the qpid-cpp-python3 branch May 9, 2022 13:16
@nagy nagy mentioned this pull request May 26, 2022
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants