-
-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[py]qtwebengine: meta.platforms; use in qutebrowser, calibre #170196
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything is OK. Now rebase/squash the commits, cleaning them up (no need for those meta-comments).
Squashed back to four commits. Let me know if you'd like it all squashed to a single commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, LGTBorg.
Description of changes
This four-patch series does the following:
qtwebengine
: implementmeta.platforms
correctly, based on the current state as of qtwebengine 5.15.8. Previously, meta.platforms was simply set to platforms.unix, which is certainly not correct. In particular, powerpc64le is not supported right now (but see below)pyqtwebengine
: do not claim enablement for a platform which is unsupported byqtwebengine
.qutebrowser
: do not claim enablement on platforms where the underlying backend (pyqtwebkit
orpyqtwebengine
) is not enabled. This is straightforward; if the chosen backend does not work thenqutebrowser
cannot do much.calibre
: on platforms whereqtwebengine
is not enabled, simply omitqtwebengine
rather than failing the build. Most of calibre's functionality does not require a web browser, so disabling calibre simply becauseqtwebengine
is unavailable is overaggressive.As of this moment
qtwebengine
is not supported on powerpc64le. However that is likely to change soon; the upstream chromium has a full javascript JIT for powerpc64le (which is already used innodejs
on powerpc64le), and gentoo is shipping a usable qtwebengine on ppc64:https://packages.gentoo.org/packages/dev-qt/qtwebengine
Things done
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)