Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

evtest: update sha256 hash #170349

Merged
merged 1 commit into from Apr 26, 2022
Merged

evtest: update sha256 hash #170349

merged 1 commit into from Apr 26, 2022

Conversation

ghost
Copy link

@ghost ghost commented Apr 26, 2022

Description of changes

Commit 6df37c9 bumped the version of
evtest but failed to update the hash. As a result, hosts which
already have evtest-1.33 source present will build the old version but
label it as evtest-1.34. Hosts which lack the older source code will
fail their builds. This commit corrects the issue.

We should think about a way to get Hydra to catch issues like this.
Maybe require that if two FODs have different hashes then they must
have different ${pname}-${version}s? Only for FODs, of course.

Things done
  • Built on platform(s)
    • powerpc64le-linux
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

Commit 6df37c9 bumped the version of
evtest but failed to update the hash.  As a result, hosts which
already have evtest-1.33 source present will build the old version but
label it as evtest-1.34.  Hosts which lack the older source code will
fail their builds.  This commit corrects the issue.

We should think about a way to get Hydra to catch issues like this.
Maybe require that if two FODs have different hashes then they must
have different `${pname}-${version}`s?  Only for FODs, of course.
@ofborg ofborg bot requested a review from bjornfor April 26, 2022 01:38
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Apr 26, 2022
Copy link
Contributor

@bjornfor bjornfor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! (And silly me!)

@github-actions
Copy link
Contributor

Successfully created backport PR #170388 for release-21.11.

@github-actions
Copy link
Contributor

The process '/usr/bin/git' failed with exit code 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant