-
-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lib/systems/platforms.nix: use "32" instead of "o32" for mips32 ABI #170736
Conversation
There is only one ABI for 32-bit MIPS chips. Before mips64, it didn't really have a name. The 64-bit MIPS ABI comes in two flavors, "n64" and "n32". It is commonplace to refer to the old 32-bit ABI as "o32" (MIPS and SGI documents do this). However, when configuring gcc, one must use --with-abi=32, not --with-abi=o32. Let's keep GCC happy with this commit.
Ping... This is a pretty low-risk merge. |
Ping |
OK, this seems like a step forward, but locally it's not a full success for me:
|
I'm running this now at |
Yes, that does succeed (cached from the attempt above apparently). My command above only fails in the very last build step. |
Oh, in that case it isn't #168650, and I think Hydra will be fine (but still checking anyways -- about halfway built). I seem to recall running into that error before... |
Yeah Hydra will be fine.
(I reordered the lines above) The last two derivations can only be built on However this will work:
Also,
I think there's something in the |
|
Description of changes
There is only one ABI for 32-bit MIPS chips. Before mips64, it didn't really have a name.
The 64-bit MIPS ABI comes in two flavors, "n64" and "n32". It is commonplace to refer to the old 32-bit ABI as "o32" (MIPS and SGI documents do this).
However, when configuring gcc, one must use
--with-abi=32
, not--with-abi=o32
.Let's keep GCC happy with this commit.
Things done
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)