Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

db-4.8.nix: add -Wno-format-security if hostPlatform.isStatic #170753

Closed
wants to merge 1 commit into from
Closed

db-4.8.nix: add -Wno-format-security if hostPlatform.isStatic #170753

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Apr 28, 2022

Description of changes

Without this commit, pkgsStatic.db48 fails to build with:

../dist/../crypto/aes_method.c: In function '__aes_err':
../dist/../crypto/aes_method.c:270:2: error: format not a string literal and no format arguments [8;;https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wformat-security-Werror=format-security8;;]
270 | __db_errx(env, errstr);
| ^~~~~~~~~

Things done
  • Built on platform(s)
    • powerpc64le-linux
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Without this commit, pkgsStatic.db48 fails to build with:

  ../dist/../crypto/aes_method.c: In function '__aes_err':
  ../dist/../crypto/aes_method.c:270:2: error: format not a string literal and no format arguments [8;;https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wformat-security-Werror=format-security8;;]
     270 |  __db_errx(env, errstr);
         |  ^~~~~~~~~
@ghost
Copy link
Author

ghost commented Apr 28, 2022

Sorry, this was due to a mistake of mine.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants