Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib/flakes: move eachSystem from flake-utils #171235

Closed
wants to merge 1 commit into from

Conversation

Artturin
Copy link
Member

@Artturin Artturin commented May 2, 2022

Description of changes

moved https://github.com/numtide/flake-utils/blob/a4b154ebbdc88c8498a5c7b01589addc9e9cb678/default.nix#L75 to nixpkgs

numtide/flake-utils#62
supersedes #123117

see @lilyball comment #123117 (comment)

intentionally not added to lib to keep it only available at lib.flakes.eachSystem

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels May 2, 2022
@colemickens
Copy link
Member

random thought, what if there was another repo for experimental flake lib functions, that was then pulled into nixpkgs-lib in an experimental namespace?

That way we still have a single-lib-util-repo, but we can keep the experimental churn out of nixpkgs proper?

@Artturin
Copy link
Member Author

Artturin commented May 2, 2022

random thought, what if there was another repo for experimental flake lib functions, that was then pulled into nixpkgs-lib in an experimental namespace?

That way we still have a single-lib-util-repo, but we can keep the experimental churn out of nixpkgs proper?

nix-community/nixpkgs.lib#2

@Artturin
Copy link
Member Author

Artturin commented May 3, 2022

@Artturin Artturin closed this May 3, 2022
@lilyball
Copy link
Member

lilyball commented May 5, 2022

I don't see how this is any better than just using flake-utils directly. The whole point of the request was that eachSystem is such an incredibly common thing to need that nixpkgs really should provide it directly (especially since eachDefaultSystem's definition is based on what hydra supports for nixpkgs). Writing lib-aggregate.lib.flake-utils.eachSystem really doesn't help anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants