Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gfold: 3.0.0 -> 4.0.0 #172368

Merged
merged 1 commit into from
May 14, 2022
Merged

gfold: 3.0.0 -> 4.0.0 #172368

merged 1 commit into from
May 14, 2022

Conversation

shanesveller
Copy link
Contributor

@shanesveller shanesveller commented May 10, 2022 •
edited
Loading

Description of changes

No intermediate non-RC versions were published between 3.0.0 and 4.0.0.

https://github.com/nickgerace/gfold/blob/4.0.0/CHANGELOG.md

Specific callouts:

Added:

git2-rs, which replaces git subcommand usage
Even though git subcommands were used over git2-rs to reduce binary size, significant speed increases could only be achieved by using the latter

Removed

git subcommand usage

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@shanesveller
Copy link
Contributor Author

shanesveller commented May 10, 2022 •
edited
Loading

nix shell .#nixpkgs-review --command bash -c "nixpkgs-review pr 172368" on my Intel Darwin machine was happy, on NixOS 21.11 I get seemingly unrelated errors in the plumbing. If they are indicative of real problems I'm happy to investigate further, but a typical nix build .#gfold and poking at ./result/bin/gfold has a superficially working binary.

Stack trace 
❯ nix shell .#nixpkgs-review --command bash -c "nixpkgs-review pr 172368"
$ git -c fetch.prune=false fetch --no-tags --force https://github.com/NixOS/nixpkgs master:refs/nixpkgs-review/0 pull/172368/head:refs/nixpkgs-review/1
From ssh://github.com/NixOS/nixpkgs
 + 25927e0666e...a0d3550e90f refs/pull/172368/head -> refs/nixpkgs-review/1  (forced update)
$ git worktree add /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs 76d686ab981f013ae1bf51a03feb076fa07a90cc
Preparing worktree (detached HEAD 76d686ab981)
Updating files: 100% (30462/30462), done.
HEAD is now at 76d686ab981 Merge pull request #169423 from mweinelt/microcode-intel
$ nix-env --option system x86_64-linux -f /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs -qaP --xml --out-path --show-trace
error: undefined variable 'TestMore'

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/pkgs/development/tools/misc/hydra/common.nix:84:9:

           83|         Test2Harness
           84|         TestMore
             |         ^
           85|         TestPostgreSQL

       … while evaluating 'go'

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/lib/deprecated.nix:92:18:

           91|   uniqList = { inputList, acc ? [] }:
           92|     let go = xs: acc:
             |                  ^
           93|              if xs == []

       … from call site

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/lib/deprecated.nix:97:27:

           96|                       y = if elem x acc then [] else [x];
           97|                   in y ++ go (tail xs) (y ++ acc);
             |                           ^
           98|     in go inputList acc;

       … while evaluating 'go'

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/lib/deprecated.nix:92:18:

           91|   uniqList = { inputList, acc ? [] }:
           92|     let go = xs: acc:
             |                  ^
           93|              if xs == []

       … from call site

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/lib/deprecated.nix:97:27:

           96|                       y = if elem x acc then [] else [x];
           97|                   in y ++ go (tail xs) (y ++ acc);
             |                           ^
           98|     in go inputList acc;

       … while evaluating 'go'

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/lib/deprecated.nix:92:18:

           91|   uniqList = { inputList, acc ? [] }:
           92|     let go = xs: acc:
             |                  ^
           93|              if xs == []

       … from call site

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/lib/deprecated.nix:97:27:

           96|                       y = if elem x acc then [] else [x];
           97|                   in y ++ go (tail xs) (y ++ acc);
             |                           ^
           98|     in go inputList acc;

       … while evaluating 'go'

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/lib/deprecated.nix:92:18:

           91|   uniqList = { inputList, acc ? [] }:
           92|     let go = xs: acc:
             |                  ^
           93|              if xs == []

       … from call site

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/lib/deprecated.nix:97:27:

           96|                       y = if elem x acc then [] else [x];
           97|                   in y ++ go (tail xs) (y ++ acc);
             |                           ^
           98|     in go inputList acc;

       … while evaluating 'go'

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/lib/deprecated.nix:92:18:

           91|   uniqList = { inputList, acc ? [] }:
           92|     let go = xs: acc:
             |                  ^
           93|              if xs == []

       … from call site

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/lib/deprecated.nix:97:27:

           96|                       y = if elem x acc then [] else [x];
           97|                   in y ++ go (tail xs) (y ++ acc);
             |                           ^
           98|     in go inputList acc;

       … while evaluating 'go'

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/lib/deprecated.nix:92:18:

           91|   uniqList = { inputList, acc ? [] }:
           92|     let go = xs: acc:
             |                  ^
           93|              if xs == []

       … from call site

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/lib/deprecated.nix:97:27:

           96|                       y = if elem x acc then [] else [x];
           97|                   in y ++ go (tail xs) (y ++ acc);
             |                           ^
           98|     in go inputList acc;

       … while evaluating 'go'

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/lib/deprecated.nix:92:18:

           91|   uniqList = { inputList, acc ? [] }:
           92|     let go = xs: acc:
             |                  ^
           93|              if xs == []

       … from call site

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/lib/deprecated.nix:97:27:

           96|                       y = if elem x acc then [] else [x];
           97|                   in y ++ go (tail xs) (y ++ acc);
             |                           ^
           98|     in go inputList acc;

       … while evaluating 'go'

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/lib/deprecated.nix:92:18:

           91|   uniqList = { inputList, acc ? [] }:
           92|     let go = xs: acc:
             |                  ^
           93|              if xs == []

       … from call site

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/lib/deprecated.nix:97:27:

           96|                       y = if elem x acc then [] else [x];
           97|                   in y ++ go (tail xs) (y ++ acc);
             |                           ^
           98|     in go inputList acc;

       … while evaluating 'go'

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/lib/deprecated.nix:92:18:

           91|   uniqList = { inputList, acc ? [] }:
           92|     let go = xs: acc:
             |                  ^
           93|              if xs == []

       … from call site

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/lib/deprecated.nix:97:27:

           96|                       y = if elem x acc then [] else [x];
           97|                   in y ++ go (tail xs) (y ++ acc);
             |                           ^
           98|     in go inputList acc;

       … while evaluating 'go'

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/lib/deprecated.nix:92:18:

           91|   uniqList = { inputList, acc ? [] }:
           92|     let go = xs: acc:
             |                  ^
           93|              if xs == []

       … from call site

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/lib/deprecated.nix:97:27:

           96|                       y = if elem x acc then [] else [x];
           97|                   in y ++ go (tail xs) (y ++ acc);
             |                           ^
           98|     in go inputList acc;

       … while evaluating 'go'

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/lib/deprecated.nix:92:18:

           91|   uniqList = { inputList, acc ? [] }:
           92|     let go = xs: acc:
             |                  ^
           93|              if xs == []

       … from call site

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/lib/deprecated.nix:97:27:

           96|                       y = if elem x acc then [] else [x];
           97|                   in y ++ go (tail xs) (y ++ acc);
             |                           ^
           98|     in go inputList acc;

       … while evaluating 'go'

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/lib/deprecated.nix:92:18:

           91|   uniqList = { inputList, acc ? [] }:
           92|     let go = xs: acc:
             |                  ^
           93|              if xs == []

       … from call site

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/lib/deprecated.nix:97:27:

           96|                       y = if elem x acc then [] else [x];
           97|                   in y ++ go (tail xs) (y ++ acc);
             |                           ^
           98|     in go inputList acc;

       … while evaluating 'go'

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/lib/deprecated.nix:92:18:

           91|   uniqList = { inputList, acc ? [] }:
           92|     let go = xs: acc:
             |                  ^
           93|              if xs == []

       … from call site

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/lib/deprecated.nix:97:27:

           96|                       y = if elem x acc then [] else [x];
           97|                   in y ++ go (tail xs) (y ++ acc);
             |                           ^
           98|     in go inputList acc;

       … while evaluating 'go'

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/lib/deprecated.nix:92:18:

           91|   uniqList = { inputList, acc ? [] }:
           92|     let go = xs: acc:
             |                  ^
           93|              if xs == []

       … from call site

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/lib/deprecated.nix:97:27:

           96|                       y = if elem x acc then [] else [x];
           97|                   in y ++ go (tail xs) (y ++ acc);
             |                           ^
           98|     in go inputList acc;

       … while evaluating 'go'

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/lib/deprecated.nix:92:18:

           91|   uniqList = { inputList, acc ? [] }:
           92|     let go = xs: acc:
             |                  ^
           93|              if xs == []

       … from call site

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/lib/deprecated.nix:97:27:

           96|                       y = if elem x acc then [] else [x];
           97|                   in y ++ go (tail xs) (y ++ acc);
             |                           ^
           98|     in go inputList acc;

       … while evaluating 'go'

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/lib/deprecated.nix:92:18:

           91|   uniqList = { inputList, acc ? [] }:
           92|     let go = xs: acc:
             |                  ^
           93|              if xs == []

       … from call site

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/lib/deprecated.nix:97:27:

           96|                       y = if elem x acc then [] else [x];
           97|                   in y ++ go (tail xs) (y ++ acc);
             |                           ^
           98|     in go inputList acc;

       … while evaluating 'go'

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/lib/deprecated.nix:92:18:

           91|   uniqList = { inputList, acc ? [] }:
           92|     let go = xs: acc:
             |                  ^
           93|              if xs == []

       … from call site

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/lib/deprecated.nix:97:27:

           96|                       y = if elem x acc then [] else [x];
           97|                   in y ++ go (tail xs) (y ++ acc);
             |                           ^
           98|     in go inputList acc;

       … while evaluating 'go'

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/lib/deprecated.nix:92:18:

           91|   uniqList = { inputList, acc ? [] }:
           92|     let go = xs: acc:
             |                  ^
           93|              if xs == []

       … from call site

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/lib/deprecated.nix:97:27:

           96|                       y = if elem x acc then [] else [x];
           97|                   in y ++ go (tail xs) (y ++ acc);
             |                           ^
           98|     in go inputList acc;

       … while evaluating 'go'

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/lib/deprecated.nix:92:18:

           91|   uniqList = { inputList, acc ? [] }:
           92|     let go = xs: acc:
             |                  ^
           93|              if xs == []

       … from call site

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/lib/deprecated.nix:97:27:

           96|                       y = if elem x acc then [] else [x];
           97|                   in y ++ go (tail xs) (y ++ acc);
             |                           ^
           98|     in go inputList acc;

       … while evaluating 'go'

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/lib/deprecated.nix:92:18:

           91|   uniqList = { inputList, acc ? [] }:
           92|     let go = xs: acc:
             |                  ^
           93|              if xs == []

       … from call site

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/lib/deprecated.nix:97:27:

           96|                       y = if elem x acc then [] else [x];
           97|                   in y ++ go (tail xs) (y ++ acc);
             |                           ^
           98|     in go inputList acc;

       … while evaluating 'go'

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/lib/deprecated.nix:92:18:

           91|   uniqList = { inputList, acc ? [] }:
           92|     let go = xs: acc:
             |                  ^
           93|              if xs == []

       … from call site

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/lib/deprecated.nix:97:27:

           96|                       y = if elem x acc then [] else [x];
           97|                   in y ++ go (tail xs) (y ++ acc);
             |                           ^
           98|     in go inputList acc;

       … while evaluating 'go'

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/lib/deprecated.nix:92:18:

           91|   uniqList = { inputList, acc ? [] }:
           92|     let go = xs: acc:
             |                  ^
           93|              if xs == []

       … from call site

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/lib/deprecated.nix:97:27:

           96|                       y = if elem x acc then [] else [x];
           97|                   in y ++ go (tail xs) (y ++ acc);
             |                           ^
           98|     in go inputList acc;

       … while evaluating 'go'

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/lib/deprecated.nix:92:18:

           91|   uniqList = { inputList, acc ? [] }:
           92|     let go = xs: acc:
             |                  ^
           93|              if xs == []

       … from call site

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/lib/deprecated.nix:97:27:

           96|                       y = if elem x acc then [] else [x];
           97|                   in y ++ go (tail xs) (y ++ acc);
             |                           ^
           98|     in go inputList acc;

       … while evaluating 'go'

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/lib/deprecated.nix:92:18:

           91|   uniqList = { inputList, acc ? [] }:
           92|     let go = xs: acc:
             |                  ^
           93|              if xs == []

       … from call site

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/lib/deprecated.nix:97:27:

           96|                       y = if elem x acc then [] else [x];
           97|                   in y ++ go (tail xs) (y ++ acc);
             |                           ^
           98|     in go inputList acc;

       … while evaluating 'go'

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/lib/deprecated.nix:92:18:

           91|   uniqList = { inputList, acc ? [] }:
           92|     let go = xs: acc:
             |                  ^
           93|              if xs == []

       … from call site

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/lib/deprecated.nix:97:27:

           96|                       y = if elem x acc then [] else [x];
           97|                   in y ++ go (tail xs) (y ++ acc);
             |                           ^
           98|     in go inputList acc;

       … while evaluating 'go'

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/lib/deprecated.nix:92:18:

           91|   uniqList = { inputList, acc ? [] }:
           92|     let go = xs: acc:
             |                  ^
           93|              if xs == []

       … from call site

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/lib/deprecated.nix:97:27:

           96|                       y = if elem x acc then [] else [x];
           97|                   in y ++ go (tail xs) (y ++ acc);
             |                           ^
           98|     in go inputList acc;

       … while evaluating 'go'

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/lib/deprecated.nix:92:18:

           91|   uniqList = { inputList, acc ? [] }:
           92|     let go = xs: acc:
             |                  ^
           93|              if xs == []

       … from call site

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/lib/deprecated.nix:97:27:

           96|                       y = if elem x acc then [] else [x];
           97|                   in y ++ go (tail xs) (y ++ acc);
             |                           ^
           98|     in go inputList acc;

       … while evaluating 'go'

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/lib/deprecated.nix:92:18:

           91|   uniqList = { inputList, acc ? [] }:
           92|     let go = xs: acc:
             |                  ^
           93|              if xs == []

       … from call site

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/lib/deprecated.nix:97:27:

           96|                       y = if elem x acc then [] else [x];
           97|                   in y ++ go (tail xs) (y ++ acc);
             |                           ^
           98|     in go inputList acc;

       … while evaluating 'go'

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/lib/deprecated.nix:92:18:

           91|   uniqList = { inputList, acc ? [] }:
           92|     let go = xs: acc:
             |                  ^
           93|              if xs == []

       … from call site

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/lib/deprecated.nix:97:27:

           96|                       y = if elem x acc then [] else [x];
           97|                   in y ++ go (tail xs) (y ++ acc);
             |                           ^
           98|     in go inputList acc;

       … while evaluating 'go'

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/lib/deprecated.nix:92:18:

           91|   uniqList = { inputList, acc ? [] }:
           92|     let go = xs: acc:
             |                  ^
           93|              if xs == []

       … from call site

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/lib/deprecated.nix:97:27:

           96|                       y = if elem x acc then [] else [x];
           97|                   in y ++ go (tail xs) (y ++ acc);
             |                           ^
           98|     in go inputList acc;

       … while evaluating 'go'

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/lib/deprecated.nix:92:18:

           91|   uniqList = { inputList, acc ? [] }:
           92|     let go = xs: acc:
             |                  ^
           93|              if xs == []

       … from call site

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/lib/deprecated.nix:97:27:

           96|                       y = if elem x acc then [] else [x];
           97|                   in y ++ go (tail xs) (y ++ acc);
             |                           ^
           98|     in go inputList acc;

       … while evaluating 'go'

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/lib/deprecated.nix:92:18:

           91|   uniqList = { inputList, acc ? [] }:
           92|     let go = xs: acc:
             |                  ^
           93|              if xs == []

       … from call site

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/lib/deprecated.nix:97:27:

           96|                       y = if elem x acc then [] else [x];
           97|                   in y ++ go (tail xs) (y ++ acc);
             |                           ^
           98|     in go inputList acc;

       … while evaluating 'go'

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/lib/deprecated.nix:92:18:

           91|   uniqList = { inputList, acc ? [] }:
           92|     let go = xs: acc:
             |                  ^
           93|              if xs == []

       … from call site

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/lib/deprecated.nix:97:27:

           96|                       y = if elem x acc then [] else [x];
           97|                   in y ++ go (tail xs) (y ++ acc);
             |                           ^
           98|     in go inputList acc;

       … while evaluating 'go'

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/lib/deprecated.nix:92:18:

           91|   uniqList = { inputList, acc ? [] }:
           92|     let go = xs: acc:
             |                  ^
           93|              if xs == []

       … from call site

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/lib/deprecated.nix:97:27:

           96|                       y = if elem x acc then [] else [x];
           97|                   in y ++ go (tail xs) (y ++ acc);
             |                           ^
           98|     in go inputList acc;

       … while evaluating 'go'

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/lib/deprecated.nix:92:18:

           91|   uniqList = { inputList, acc ? [] }:
           92|     let go = xs: acc:
             |                  ^
           93|              if xs == []

       … from call site

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/lib/deprecated.nix:97:27:

           96|                       y = if elem x acc then [] else [x];
           97|                   in y ++ go (tail xs) (y ++ acc);
             |                           ^
           98|     in go inputList acc;

       … while evaluating 'go'

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/lib/deprecated.nix:92:18:

           91|   uniqList = { inputList, acc ? [] }:
           92|     let go = xs: acc:
             |                  ^
           93|              if xs == []

       … from call site

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/lib/deprecated.nix:97:27:

           96|                       y = if elem x acc then [] else [x];
           97|                   in y ++ go (tail xs) (y ++ acc);
             |                           ^
           98|     in go inputList acc;

       … while evaluating 'go'

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/lib/deprecated.nix:92:18:

           91|   uniqList = { inputList, acc ? [] }:
           92|     let go = xs: acc:
             |                  ^
           93|              if xs == []

       … from call site

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/lib/deprecated.nix:97:27:

           96|                       y = if elem x acc then [] else [x];
           97|                   in y ++ go (tail xs) (y ++ acc);
             |                           ^
           98|     in go inputList acc;

       … while evaluating 'go'

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/lib/deprecated.nix:92:18:

           91|   uniqList = { inputList, acc ? [] }:
           92|     let go = xs: acc:
             |                  ^
           93|              if xs == []

       … from call site

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/lib/deprecated.nix:97:27:

           96|                       y = if elem x acc then [] else [x];
           97|                   in y ++ go (tail xs) (y ++ acc);
             |                           ^
           98|     in go inputList acc;

       … while evaluating 'go'

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/lib/deprecated.nix:92:18:

           91|   uniqList = { inputList, acc ? [] }:
           92|     let go = xs: acc:
             |                  ^
           93|              if xs == []

       … from call site

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/lib/deprecated.nix:97:27:

           96|                       y = if elem x acc then [] else [x];
           97|                   in y ++ go (tail xs) (y ++ acc);
             |                           ^
           98|     in go inputList acc;

       … while evaluating 'go'

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/lib/deprecated.nix:92:18:

           91|   uniqList = { inputList, acc ? [] }:
           92|     let go = xs: acc:
             |                  ^
           93|              if xs == []

       … from call site

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/lib/deprecated.nix:97:27:

           96|                       y = if elem x acc then [] else [x];
           97|                   in y ++ go (tail xs) (y ++ acc);
             |                           ^
           98|     in go inputList acc;

       … while evaluating 'go'

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/lib/deprecated.nix:92:18:

           91|   uniqList = { inputList, acc ? [] }:
           92|     let go = xs: acc:
             |                  ^
           93|              if xs == []

       … from call site

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/lib/deprecated.nix:97:27:

           96|                       y = if elem x acc then [] else [x];
           97|                   in y ++ go (tail xs) (y ++ acc);
             |                           ^
           98|     in go inputList acc;

       … while evaluating 'go'

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/lib/deprecated.nix:92:18:

           91|   uniqList = { inputList, acc ? [] }:
           92|     let go = xs: acc:
             |                  ^
           93|              if xs == []

       … from call site

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/lib/deprecated.nix:97:27:

           96|                       y = if elem x acc then [] else [x];
           97|                   in y ++ go (tail xs) (y ++ acc);
             |                           ^
           98|     in go inputList acc;

       … while evaluating 'go'

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/lib/deprecated.nix:92:18:

           91|   uniqList = { inputList, acc ? [] }:
           92|     let go = xs: acc:
             |                  ^
           93|              if xs == []

       … from call site

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/lib/deprecated.nix:97:27:

           96|                       y = if elem x acc then [] else [x];
           97|                   in y ++ go (tail xs) (y ++ acc);
             |                           ^
           98|     in go inputList acc;

       … while evaluating 'go'

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/lib/deprecated.nix:92:18:

           91|   uniqList = { inputList, acc ? [] }:
           92|     let go = xs: acc:
             |                  ^
           93|              if xs == []

       … from call site

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/lib/deprecated.nix:97:27:

           96|                       y = if elem x acc then [] else [x];
           97|                   in y ++ go (tail xs) (y ++ acc);
             |                           ^
           98|     in go inputList acc;

       … while evaluating 'go'

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/lib/deprecated.nix:92:18:

           91|   uniqList = { inputList, acc ? [] }:
           92|     let go = xs: acc:
             |                  ^
           93|              if xs == []

       … from call site

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/lib/deprecated.nix:97:27:

           96|                       y = if elem x acc then [] else [x];
           97|                   in y ++ go (tail xs) (y ++ acc);
             |                           ^
           98|     in go inputList acc;

       … while evaluating 'go'

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/lib/deprecated.nix:92:18:

           91|   uniqList = { inputList, acc ? [] }:
           92|     let go = xs: acc:
             |                  ^
           93|              if xs == []

       … from call site

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/lib/deprecated.nix:97:27:

           96|                       y = if elem x acc then [] else [x];
           97|                   in y ++ go (tail xs) (y ++ acc);
             |                           ^
           98|     in go inputList acc;

       … while evaluating 'go'

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/lib/deprecated.nix:92:18:

           91|   uniqList = { inputList, acc ? [] }:
           92|     let go = xs: acc:
             |                  ^
           93|              if xs == []

       … from call site

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/lib/deprecated.nix:97:27:

           96|                       y = if elem x acc then [] else [x];
           97|                   in y ++ go (tail xs) (y ++ acc);
             |                           ^
           98|     in go inputList acc;

       … while evaluating 'go'

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/lib/deprecated.nix:92:18:

           91|   uniqList = { inputList, acc ? [] }:
           92|     let go = xs: acc:
             |                  ^
           93|              if xs == []

       … from call site

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/lib/deprecated.nix:97:27:

           96|                       y = if elem x acc then [] else [x];
           97|                   in y ++ go (tail xs) (y ++ acc);
             |                           ^
           98|     in go inputList acc;

       … while evaluating 'go'

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/lib/deprecated.nix:92:18:

           91|   uniqList = { inputList, acc ? [] }:
           92|     let go = xs: acc:
             |                  ^
           93|              if xs == []

       … from call site

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/lib/deprecated.nix:97:27:

           96|                       y = if elem x acc then [] else [x];
           97|                   in y ++ go (tail xs) (y ++ acc);
             |                           ^
           98|     in go inputList acc;

       … while evaluating 'go'

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/lib/deprecated.nix:92:18:

           91|   uniqList = { inputList, acc ? [] }:
           92|     let go = xs: acc:
             |                  ^
           93|              if xs == []

       … from call site

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/lib/deprecated.nix:97:27:

           96|                       y = if elem x acc then [] else [x];
           97|                   in y ++ go (tail xs) (y ++ acc);
             |                           ^
           98|     in go inputList acc;

       … while evaluating 'go'

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/lib/deprecated.nix:92:18:

           91|   uniqList = { inputList, acc ? [] }:
           92|     let go = xs: acc:
             |                  ^
           93|              if xs == []

       … from call site

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/lib/deprecated.nix:97:27:

           96|                       y = if elem x acc then [] else [x];
           97|                   in y ++ go (tail xs) (y ++ acc);
             |                           ^
           98|     in go inputList acc;

       … while evaluating 'go'

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/lib/deprecated.nix:92:18:

           91|   uniqList = { inputList, acc ? [] }:
           92|     let go = xs: acc:
             |                  ^
           93|              if xs == []

       … from call site

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/lib/deprecated.nix:97:27:

           96|                       y = if elem x acc then [] else [x];
           97|                   in y ++ go (tail xs) (y ++ acc);
             |                           ^
           98|     in go inputList acc;

       … while evaluating 'go'

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/lib/deprecated.nix:92:18:

           91|   uniqList = { inputList, acc ? [] }:
           92|     let go = xs: acc:
             |                  ^
           93|              if xs == []

       … from call site

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/lib/deprecated.nix:97:27:

           96|                       y = if elem x acc then [] else [x];
           97|                   in y ++ go (tail xs) (y ++ acc);
             |                           ^
           98|     in go inputList acc;

       … while evaluating 'go'

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/lib/deprecated.nix:92:18:

           91|   uniqList = { inputList, acc ? [] }:
           92|     let go = xs: acc:
             |                  ^
           93|              if xs == []

       … from call site

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/lib/deprecated.nix:97:27:

           96|                       y = if elem x acc then [] else [x];
           97|                   in y ++ go (tail xs) (y ++ acc);
             |                           ^
           98|     in go inputList acc;

       … while evaluating 'go'

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/lib/deprecated.nix:92:18:

           91|   uniqList = { inputList, acc ? [] }:
           92|     let go = xs: acc:
             |                  ^
           93|              if xs == []

       … from call site

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/lib/deprecated.nix:97:27:

           96|                       y = if elem x acc then [] else [x];
           97|                   in y ++ go (tail xs) (y ++ acc);
             |                           ^
           98|     in go inputList acc;

       … while evaluating 'go'

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/lib/deprecated.nix:92:18:

           91|   uniqList = { inputList, acc ? [] }:
           92|     let go = xs: acc:
             |                  ^
           93|              if xs == []

       … from call site

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/lib/deprecated.nix:97:27:

           96|                       y = if elem x acc then [] else [x];
           97|                   in y ++ go (tail xs) (y ++ acc);
             |                           ^
           98|     in go inputList acc;

       … while evaluating 'go'

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/lib/deprecated.nix:92:18:

           91|   uniqList = { inputList, acc ? [] }:
           92|     let go = xs: acc:
             |                  ^
           93|              if xs == []

       … from call site

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/lib/deprecated.nix:97:27:

           96|                       y = if elem x acc then [] else [x];
           97|                   in y ++ go (tail xs) (y ++ acc);
             |                           ^
           98|     in go inputList acc;

       … while evaluating 'go'

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/lib/deprecated.nix:92:18:

           91|   uniqList = { inputList, acc ? [] }:
           92|     let go = xs: acc:
             |                  ^
           93|              if xs == []

       … from call site

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/lib/deprecated.nix:98:8:

           97|                   in y ++ go (tail xs) (y ++ acc);
           98|     in go inputList acc;
             |        ^
           99|

       … while evaluating 'uniqList'

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/lib/deprecated.nix:91:14:

           90|   # This function has O(n^2) performance.
           91|   uniqList = { inputList, acc ? [] }:
             |              ^
           92|     let go = xs: acc:

       … from call site

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/lib/deprecated.nix:153:24:

          152|                       acc'
          153|                       (uniqList { inputList = (maybeAttrNullable "propagatedBuildInputs" [] y)
             |                        ^
          154|                                            ++ (maybeAttrNullable "propagatedNativeBuildInputs" [] y)

       … while evaluating 'innerClosePropagation'

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/lib/deprecated.nix:143:32:

          142|
          143|   innerClosePropagation = acc: xs:
             |                                ^
          144|     if xs == []

       … from call site

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/lib/deprecated.nix:151:21:

          150|             else let acc' = [y] ++ acc;
          151|                  in innerClosePropagation
             |                     ^
          152|                       acc'

       … while evaluating 'innerClosePropagation'

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/lib/deprecated.nix:143:32:

          142|
          143|   innerClosePropagation = acc: xs:
             |                                ^
          144|     if xs == []

       … from call site

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/lib/deprecated.nix:160:52:

          159|
          160|   closePropagation = list: (uniqList {inputList = (innerClosePropagation [] list);});
             |                                                    ^
          161|

       … while evaluating 'go'

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/lib/deprecated.nix:92:18:

           91|   uniqList = { inputList, acc ? [] }:
           92|     let go = xs: acc:
             |                  ^
           93|              if xs == []

       … from call site

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/lib/deprecated.nix:98:8:

           97|                   in y ++ go (tail xs) (y ++ acc);
           98|     in go inputList acc;
             |        ^
           99|

       … while evaluating 'uniqList'

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/lib/deprecated.nix:91:14:

           90|   # This function has O(n^2) performance.
           91|   uniqList = { inputList, acc ? [] }:
             |              ^
           92|     let go = xs: acc:

       … from call site

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/lib/deprecated.nix:160:29:

          159|
          160|   closePropagation = list: (uniqList {inputList = (innerClosePropagation [] list);});
             |                             ^
          161|

       … while evaluating 'closePropagation'

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/lib/deprecated.nix:160:22:

          159|
          160|   closePropagation = list: (uniqList {inputList = (innerClosePropagation [] list);});
             |                      ^
          161|

       … from call site

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/pkgs/development/tools/misc/hydra/common.nix:25:32:

           24|     name = "hydra-perl-deps";
           25|     paths = with perlPackages; lib.closePropagation
             |                                ^
           26|       [ ModulePluggable

       … while evaluating the attribute 'passAsFile'

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/pkgs/build-support/buildenv/default.nix:77:5:

           76|     # XXX: The size is somewhat arbitrary
           77|     passAsFile = if builtins.stringLength pkgs >= 128*1024 then [ "pkgs" ] else [ ];
             |     ^
           78|   }

       … while evaluating the attribute 'passAsFile' of the derivation 'hydra-perl-deps'

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/pkgs/stdenv/generic/make-derivation.nix:270:7:

          269|     // (lib.optionalAttrs (attrs ? name || (attrs ? pname && attrs ? version)) {
          270|       name =
             |       ^
          271|         let

       … while evaluating the attribute 'buildInputs' of the derivation 'hydra-2022-02-07'

       at /home/shane/.cache/nixpkgs-review/pr-172368-6/nixpkgs/pkgs/stdenv/generic/make-derivation.nix:270:7:

          269|     // (lib.optionalAttrs (attrs ? name || (attrs ? pname && attrs ? version)) {
          270|       name =
             |       ^
          271|         let

       … while querying the derivation named 'hydra-2022-02-07'
https://github.com/NixOS/nixpkgs/pull/172368 failed to build
$ git worktree prune

@Artturin
Copy link
Member

nix shell .#nixpkgs-review --command bash -c "nixpkgs-review pr 172368" on my Intel Darwin machine was happy, on NixOS 21.11 I get seemingly unrelated errors in the plumbing. If they are indicative of real problems I'm happy to investigate further, but a typical nix build .#gfold and poking at ./result/bin/gfold has a superficially working binary.
Stack trace

That issue is now fixed

@Artturin
Copy link
Member

If possible a https://nixos.org/manual/nixpkgs/unstable/#tester-testVersion would be nice.

@shanesveller
Copy link
Contributor Author

shanesveller commented May 13, 2022 •
edited
Loading

If possible a https://nixos.org/manual/nixpkgs/unstable/#tester-testVersion would be nice.

@Artturin thanks for the suggestion, I hadn't seen these before! I attempted to incorporate it in 29d7c4f5047951ce4cdec91521400330084a7766 ee539d331d718ab5def00fc5a1888a7f6777bc78.

I tried the following with a fake value to see it fail. Is there a technique to run said test other than this?

nix -vL build .#gfold.passthru.tests.version

Artturin
Artturin reviewed May 13, 2022
View reviewed changes
pkgs/applications/version-management/git-and-tools/gfold/default.nix Outdated
package = gfold;
command = "gfold --version";
inherit version;
};

meta = with lib; {
inherit (src.meta) homepage;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the eval is failing due to this

please change it to a clickable url so we can click on it

@Artturin
Copy link
Member

Artturin commented May 13, 2022 •
edited
Loading

If possible a nixos.org/manual/nixpkgs/unstable/#tester-testVersion would be nice.

@Artturin thanks for the suggestion, I hadn't seen these before! I attempted to incorporate it in 29d7c4f ee539d3.

I tried the following with a fake value to see it fail. Is there a technique to run said test other than this?

nix -vL build .#gfold.passthru.tests.version

https://nixos.org/manual/nixpkgs/stable/#special-variables
you can just do gfold.tests.version

currently there's a rfc to improve testing NixOS/rfcs#119

@siraben
Copy link
Member

siraben commented May 13, 2022

Result of nixpkgs-review pr 172368 run on aarch64-darwin 1

@Artturin Artturin merged commit b7a7846 into NixOS:master May 14, 2022
@shanesveller shanesveller deleted the shanesveller/gfold-4.0 branch May 14, 2022 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Artturin Artturin Artturin left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shanesveller @Artturin @siraben