Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ssocr: unstable-2018-08-11 -> 2.22.1 #172444

Merged
merged 2 commits into from May 12, 2022
Merged

ssocr: unstable-2018-08-11 -> 2.22.1 #172444

merged 2 commits into from May 12, 2022

Conversation

ghost
Copy link

@ghost ghost commented May 11, 2022

ZHF: #172160

Description of changes

Prior to this commit, ssocr's build was broken due to imlib moving to
pkg-config and removing the imlib2-config program.

This commit upgrades to the latest upstream, which understands
pkg-config. It also corrects some buildInputs/nativeBuildInputs
hygiene issues.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ghost
Copy link
Author

ghost commented May 11, 2022

The ZHF announcement PR says: "Please ping @NixOS/nixos-release-managers on the PR and add the 0.kind: build failure label to the pull request. If you're unable to because you're not a member of the NixOS org please ping @dasJ, @tomberek, @jonringer, @Mic92"

I am unable to add this build label, so I therefore am issuing this ping.

@ghost ghost changed the title ssocr: upgrade to a version that understands pkg-config ssocr: unstable-2018-08-11 -> 2.22.1 May 11, 2022
@ghost
Copy link
Author

ghost commented May 12, 2022

Tested and squashed. Thanks!

Adam Joseph and others added 2 commits May 11, 2022 23:57
Prior to this commit, ssocr's build was broken due to imlib moving to
pkg-config and removing the imlib2-config program.

This commit upgrades to the latest upstream, which understands
pkg-config.  It also corrects some buildInputs/nativeBuildInputs
hygiene issues.

Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
@thiagokokada
Copy link
Contributor

Result of nixpkgs-review pr 172444 run on x86_64-linux 1

1 package built:
  • ssocr

@SuperSandro2000 SuperSandro2000 merged commit 59ee75c into NixOS:master May 12, 2022
@ghost ghost deleted the pr/zhf/ssocr branch January 23, 2024 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants