Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "lib: init flakes.nix" #173093

Merged
merged 1 commit into from
May 15, 2022

Conversation

adisbladis
Copy link
Member

@adisbladis adisbladis commented May 15, 2022

Description of changes

This reverts PR #167947.

Flakes aren't standardised and the lib namespace shouldn't be polluted with utilities that serve only experimental uses.

If you want this go participate in the RFC, then come back once the interface is no longer experimental.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@adisbladis adisbladis mentioned this pull request May 15, 2022
13 tasks
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels May 15, 2022
@sternenseemann
Copy link
Member

I don't see why this has to be in nixpkgs . In the light of recent larger changes to lib being rejected until either an RFC about them specifically was accepted, I don't see why adding this has justification.

Since we don't have NixOS/rfcs#82, keeping the flakes lib in a stable release would essentially declare something as stable that is not sure to be (or to stay around even).

This reverts commit PR NixOS#167947.

Flakes aren't standardised and the `lib` namespace shouldn't be
polluted with utilities that serve only experimental uses.
@adisbladis adisbladis force-pushed the lib-flakes-nix-revert branch from 407a3a8 to 161776e Compare May 15, 2022 10:40
@sternenseemann sternenseemann merged commit e42d059 into NixOS:master May 15, 2022
@roberth
Copy link
Member

roberth commented May 15, 2022

If you want this go participate in the RFC, then come back once the interface is no longer experimental.

I sense some frustration here. I know of many reasons why that may be, but not everyone does, and we have to consider that we're in a position of power as maintainers. But alas, maybe I am the one reading too much into this. I'll stop.

RFC 82

Yes please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants