coreboot-toolchain: if gnat11.meta.broken then omit ada #173808
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gnat requires a long and increasingly-fragile bootstrapping chain; it broke days before ZHF 22.05, which risked causing coreboot-tools to be marked broken. To guard against this in the future, we fall back to omitting ada support (and therefore libgfxinit) rather than failing completely. Tested with gnat11 marked broken. On my system, PR #171223 is also required in order to fully unbreak coreboot-toolchain. YMMV.
ofborg
bot
added
10.rebuild-darwin: 0
ghost
mentioned this pull request
|
@ofborg build coreboot-toolchain |
ghost
mentioned this pull request
5 tasks
|
ofborg says: coreboot-toolchain on x86_64-linux — Success My own rebuild |
ghost
marked this pull request as ready for review
|
I will reply later in the day. I don't have time now. |
|
Closed by #173893 (for this release cycle, at least) |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ZHF: #172160
Description of changes
Gnat requires a long and increasingly-fragile bootstrapping chain; it has been broken in past releases and recently broke just six days before the end of ZHF 22.05, and remains broken, which puts coreboot-tools at risk of being marked broken in the 22.05 release. The only proposed fix for gnat requires a patch to
glibc, which would cause a global rebuild; the ZHF managers are unlikely to agree to something like that with 10 days left until release.To guard against
coreboot-toolsbeing marked broken in 22.05 and future releases, let's fall back to omitting ada support (and therefore libgfxinit) rather than failing completely.Tested with gnat11 marked broken.
On systems that do not pull from cachix, PR #171223 is also required in order to fully unbreak coreboot-toolchain. Please consider merging that PR as well. It isn't possible to build
coreboot-toolchainwithout that; the only reason we aren't getting failures is because of cached artifacts.Things done
./result/bin/)