Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

purescript: mark meta.sourceProvenance #175501

Merged
merged 2 commits into from Jul 18, 2022
Merged

purescript: mark meta.sourceProvenance #175501

merged 2 commits into from Jul 18, 2022

Conversation

ghost
Copy link

@ghost ghost commented May 30, 2022

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ghost ghost changed the title koreader: mark meta.sourceProvenance purescript: mark meta.sourceProvenance May 30, 2022
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild labels May 30, 2022
@ghost
Copy link
Author

ghost commented Jul 11, 2022

Ping...

@cdepillabout
Copy link
Member

This LGTM, thanks.


@amjoseph-nixpkgs You generally need to cc the maintainers of the package, otherwise no one gets notified of this PR. I only saw it because I just happened to search for purescript for unrelated reasons.

@cdepillabout cdepillabout merged commit 99b97a7 into NixOS:master Jul 18, 2022
@ghost
Copy link
Author

ghost commented Jul 18, 2022

You generally need to cc the maintainers of the package, otherwise no one gets notified of this PR.

Wow, thanks for letting me know. I assumed the whole reason we put github IDs in maintainers.nix was in order to make that happen automatically.=

@ghost ghost deleted the pr/sourceProvenance/purescript branch July 18, 2022 20:10
@cdepillabout
Copy link
Member

I assumed the whole reason we put github IDs in maintainers.nix was in order to make that happen automatically.

Yeah, normally it does happen automatically. I have no idea why it didn't happen here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant