sil / sil-q: clean up and add tests #177802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add meta.mainProgram to be able to use nix run - Run preInstall and postInstall hooks - Test creation of the save directory in passthru.tests - Fix some typos and misformatting - Change prePatch to postPatch (as in the suggestion I got when adding sil-q)
Check whether creating the save directory works (as a test in passthru.tests).
kenranunderscore
force-pushed
the
small-sil-cleanup
branch
from
91966b5
to
44feda0
Compare
michaelpj
approved these changes
Jun 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Sil:
meta.mainProgramto be able to usenix runpassthru.testspreInstallandpostInstallhooksprePatchtopostPatch(as in a suggestion I received when addingsil-q)Sil-Q:
passthru.tests(same test as above, as they use the same mechanism to create the save directory)I wasn't sure whether to squash, so I kept the commits separate per package.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes