nixos/networkd: default DHCP network improvements #178046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: nixos
13 tasks
ofborg
bot
added
10.rebuild-darwin: 0
lheckemann
approved these changes
Jun 17, 2022
|
@ofborg test networking systemd-networkd |
|
@ncfavier Could you rebase this? |
When `systemd.network.wait-online.anyInterface` is enabled, `RequiredForOnline` really means "sufficient for online", so enable it.
Maybe this could go in `genericNetwork`, but I don't know if it makes sense for bridges, bonds etc. and I don't want to break anything.
ncfavier
force-pushed
the
networkd-default-improvements
branch
from
69b4ce5 to
1be4019
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
systemd.network.wait-online.anyInterfaceis enabled,RequiredForOnlinereally means "sufficient for online", so enable it.Also add
IPv6PrivacyExtensions=kernelto default networks as is done for normal interfaces. Maybe this could go ingenericNetwork, but I don't know if it makes sense for bridges, bonds etc. and I don't want to break anything.