Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re2: 2022-04-01 -> 2022-06-01 #178215

Merged
merged 1 commit into from
Jun 24, 2022
Merged

re2: 2022-04-01 -> 2022-06-01 #178215

merged 1 commit into from
Jun 24, 2022

Conversation

trofi
Copy link
Contributor

@trofi trofi commented Jun 19, 2022

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@trofi
Copy link
Contributor Author

trofi commented Jun 24, 2022

Tested as nix build --no-link github:NixOS/nixpkgs/pull/178215/merge#re2.tests.{chromium,grpc,mercurial,fb-re2,google-re2,haskellPackages-re2}. Took a while but succeeded \o/.

@trofi trofi merged commit 29cb8d0 into NixOS:staging Jun 24, 2022
@trofi trofi deleted the update-re2 branch June 24, 2022 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant