Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cilium-cli: enable shell completion #179130

Merged
merged 1 commit into from
Jun 27, 2022
Merged

cilium-cli: enable shell completion #179130

merged 1 commit into from
Jun 27, 2022

Conversation

bryanasdev000
Copy link
Member

Description of changes
  • enable shell completion
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from akshatagarwl and kalbasit June 26, 2022 00:44
@bryanasdev000 bryanasdev000 deleted the ciliumshell branch June 26, 2022 01:02
@bryanasdev000 bryanasdev000 restored the ciliumshell branch June 26, 2022 01:06
@bryanasdev000 bryanasdev000 reopened this Jun 26, 2022
@ofborg ofborg bot requested a review from akshatagarwl June 27, 2022 03:52
@marsam marsam merged commit a05fdcf into NixOS:master Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalbasit kalbasit Awaiting requested review from kalbasit

@marsam marsam Awaiting requested review from marsam

@akshatagarwl akshatagarwl Awaiting requested review from akshatagarwl

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bryanasdev000 @marsam @akshatagarwl