-
-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixos/xfconf: init #179220
nixos/xfconf: init #179220
Conversation
- Add a module for xfconf, the Xfce configuration storage system.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one concern, the rest LGTM
Didn't test locally though
}; | ||
|
||
options = { | ||
programs.xfconf = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's better if you add a package
option that defaults to pkgs.xfce.xfconf
, then pass that result to systemPackages and dbus packages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you envision a situation where one would want to override xfconf
for the module but not for the rest of the system the way overlays do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Being used by many components of Xfce, it is sensible that an override of xfconf
, if needed, would be better done system wide with overlays, for instance. So I would keep it simple and not add a package
option.
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/programs-xfconf-enable-in-configuration-nix-not-working/22066/4 |
Description of changes
Add a module for
xfconf
, the Xfce configuration storage system.It was suggested in nixos/thunar: init #179108 (comment)
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes