Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/xfconf: init #179220

Merged
merged 1 commit into from
Jun 30, 2022
Merged

nixos/xfconf: init #179220

merged 1 commit into from
Jun 30, 2022

Conversation

romildo
Copy link
Contributor

@romildo romildo commented Jun 26, 2022

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

- Add a module for xfconf, the Xfce configuration storage system.
Copy link
Contributor

@lucasew lucasew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one concern, the rest LGTM

Didn't test locally though

};

options = {
programs.xfconf = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's better if you add a package option that defaults to pkgs.xfce.xfconf, then pass that result to systemPackages and dbus packages.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you envision a situation where one would want to override xfconf for the module but not for the rest of the system the way overlays do?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Being used by many components of Xfce, it is sensible that an override of xfconf, if needed, would be better done system wide with overlays, for instance. So I would keep it simple and not add a package option.

@romildo romildo merged commit f72be3a into NixOS:master Jun 30, 2022
@romildo romildo deleted the fix.xfconf branch June 30, 2022 10:39
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/programs-xfconf-enable-in-configuration-nix-not-working/22066/4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants