Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace use of testVersion alias #179226

Merged
merged 1 commit into from
Jun 27, 2022
Merged

Replace use of testVersion alias #179226

merged 1 commit into from
Jun 27, 2022

Conversation

bdd
Copy link
Contributor

@bdd bdd commented Jun 26, 2022

  • lndconnect: Drop unused input testVersion
  • other packages: Import testers and use testers.testVersion
Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@bdd
Replace use of testVersion alias
a9f9124 
- lndconnect: Drop unused input `testVersion`
- other packages: Import `testers` and use `testers.testVersion`
@bdd bdd mentioned this pull request Jun 26, 2022
Merged
13 tasks
@Mic92 Mic92 merged commit 725cee0 into NixOS:master Jun 27, 2022
@bdd bdd deleted the use_testers_testversion branch December 4, 2022 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmahut mmahut Awaiting requested review from mmahut mmahut is a code owner

@RaghavSood RaghavSood Awaiting requested review from RaghavSood RaghavSood is a code owner

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bdd @Mic92