asciidoc: 9.1.0 -> 10.2.0 #179254
Merged
asciidoc: 9.1.0 -> 10.2.0 #179254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ofborg build asciidoc asciidoc-full asciidoc-full-with-plugins |
dotlambda
force-pushed
the
asciidoc-10.2.0
branch
from
aa19dc1
to
988d1f3
Compare
Mindavi
reviewed
Jun 27, 2022
Mindavi
reviewed
Jun 27, 2022
dotlambda
force-pushed
the
asciidoc-10.2.0
branch
from
988d1f3
to
b2f015f
Compare
Mindavi
requested changes
Jun 27, 2022
dotlambda
force-pushed
the
asciidoc-10.2.0
branch
2 times, most recently
from
3c6141d
to
c546624
Compare
I don't see a problem, |
|
I haven't tested building |
|
Heh, I'll try again, not sure what happened for me then. I wasn't building the *-full versions either. |
The fail log I getFor commit c54662430287d0f8d3fc99dea90cbbe05992f8cd on this branch. I'm really not sure what's happening, when I add |
|
Could it have something to do with binfmt being enabled on my machine? |
|
Ah yeah, it's probably just executing python for aarch64 on your machine then 😄. Probably a slight mistake in the makefile that's made :( |
Autotools doesn't substitute |
dotlambda
force-pushed
the
asciidoc-10.2.0
branch
from
c546624
to
a21e69f
Compare
|
I solved it by using |
Mindavi
reviewed
Jun 27, 2022
| @@ -17,8 +18,7 @@ | |||
| , docbook_xsl_ns ? null | |||
| , docbook_xsl ? null | |||
| , fop ? null | |||
| # TODO: Package this: | |||
| #, epubcheck ? null | |||
| , epubcheck ? null | |||
There was a problem hiding this comment.
I don't think we still need this ? null pattern here.
Mindavi
approved these changes
Jun 27, 2022
Thanks, yeah that makes most sense indeed :) |
|
Tried running the native asciidoc and pasting this in: .Onomatopoeia
====
The book hit the floor with a *thud*.
He could hear doves *cooing* in the pine trees`' branches.
====
Then running |
ofborg
bot
requested review from
mmahut,
kalbasit,
adevress,
WilliButz,
SuperSandro2000 and
globin
SuperSandro2000
approved these changes
Jun 28, 2022
|
I don't have the expertise to review this so I will not. The only reason I touched this package was to get rid of Python 2. |
|
Is anyone willing to sign the Google CLA and submit libjxl/libjxl#1541 again? |
in process |
dotlambda
force-pushed
the
asciidoc-10.2.0
branch
from
122bfca
to
335ecd7
Compare
|
I locally built asciidoc, asciidoc-full, and asciidoc-full-with-plugins. I think this is ready to go. |
SuperSandro2000
approved these changes
Jun 29, 2022
dotlambda
force-pushed
the
asciidoc-10.2.0
branch
from
335ecd7
to
77454bd
Compare
|
lets see how much will start burning |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
https://github.com/asciidoc-py/asciidoc-py/blob/10.2.0/CHANGELOG.adoc
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes