Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vscode-extensions.ms-python.python: 2022.0.1814523869 -> 2022.9.11791004 #179530

Closed
wants to merge 85 commits into from

Conversation

linsui
Copy link
Contributor

@linsui linsui commented Jun 29, 2022

Description of changes

Update and clean up.

In the latest version:

  1. Remove Microsoft Python Language Server support from the extension.

  2. Remove ctags support. Workspace symbols now supported via language servers.

so they are removed.

Python libs from nixpkgs are used so bundled files and related patches are removed. Some other deps are removed because it works without them. Not sure if they are needed for some functions not tested.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@jraygauthier @jfchevrette @mkenigs

also clean up and take up maintainership
propagatedBuildInputs = with python3.pkgs; [
debugpy
isort
jedi-language-server
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes ms-python not build on aarch64-darwin because jedi-language-server depends on pyopenssl which is marked as broken (#175875)

I'm not sure what the policy in such cases?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it break the jedi function? If the jedit still works we can use a overlay, else we should mark it broken.

Copy link
Contributor Author

@linsui linsui Jul 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed all deps pulling in pyopnessl. urllib3 is fixed in #179159. They are all deps of poetry.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pkgs/development/python-modules/httpretty/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/httpretty/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/cherrypy/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/cheroot/default.nix Outdated Show resolved Hide resolved
propagatedBuildInputs = with python3.pkgs; [
debugpy
isort
jedi-language-server
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
@jraygauthier
Copy link
Member

@linsui: you might want to symlink pythonFiles/lib/python/debugpy to nixpkgs lib/pythonX.X/site-packages/debugpy and see if it fixes the issue. It might however not work as expected if the extension depends on the specificity of a particular version of debugpy (no sure why it would, but it might).

Manually changing the configuration to point to a nix path is not a sustainable solution as debugger ends up being broken by default for everyone... An alternative might be to see if patching package.json debugAdapterPath adding a default value via jq. it might possibly not work as the entry has no default:

                            "debugAdapterPath": {
                                "description": "Path (fully qualified) to the python debug adapter executable.",
                                "type": "string"
                            },

much better in my opinion making things work without touching package.json whenever possible.

@linsui
Copy link
Contributor Author

linsui commented Jul 8, 2022

Yes, that's what I did.

@linsui
Copy link
Contributor Author

linsui commented Jul 14, 2022

@SuperSandro2000 Kindly ping :)

@SuperSandro2000
Copy link
Member

cherry-picked into the python-updates run

@linsui linsui deleted the ms-python branch July 16, 2022 00:06
@linsui
Copy link
Contributor Author

linsui commented Jul 16, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.