-
-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vscode-extensions.ms-python.python: 2022.0.1814523869 -> 2022.9.11791004 #179530
Conversation
allows using the correct package in passthru remove unneeded replaceStrings in urls
curl is built many times during a stdenv rebuild they are a bottleneck
a8dab59
to
6020a4b
Compare
also clean up and take up maintainership
propagatedBuildInputs = with python3.pkgs; [ | ||
debugpy | ||
isort | ||
jedi-language-server |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes ms-python not build on aarch64-darwin because jedi-language-server depends on pyopenssl which is marked as broken (#175875)
I'm not sure what the policy in such cases?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it break the jedi function? If the jedit still works we can use a overlay, else we should mark it broken.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed all deps pulling in pyopnessl. urllib3 is fixed in #179159. They are all deps of poetry.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
propagatedBuildInputs = with python3.pkgs; [ | ||
debugpy | ||
isort | ||
jedi-language-server |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
@linsui: you might want to symlink Manually changing the configuration to point to a nix path is not a sustainable solution as debugger ends up being broken by default for everyone... An alternative might be to see if patching
much better in my opinion making things work without touching |
Yes, that's what I did. |
@SuperSandro2000 Kindly ping :) |
cherry-picked into the python-updates run |
Thanks! |
Description of changes
Update and clean up.
In the latest version:
so they are removed.
Python libs from nixpkgs are used so bundled files and related patches are removed. Some other deps are removed because it works without them. Not sure if they are needed for some functions not tested.
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes@jraygauthier @jfchevrette @mkenigs