Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gcc10: 10.3.0 -> 10.4.0 #179534

Merged
merged 1 commit into from
Jul 1, 2022
Merged

gcc10: 10.3.0 -> 10.4.0 #179534

merged 1 commit into from
Jul 1, 2022

Conversation

vcunat
Copy link
Member

@vcunat vcunat commented Jun 29, 2022 •
edited
Loading

Patches: the two seemed included in the release;
I also checked that the conditional patches still all apply.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@vcunat
gcc10: 10.3.0 -> 10.4.0
3f88d51 
Patches: the two seemed included in the release;
I also checked that the conditional patches still all apply.
@vcunat
Copy link
Member Author

vcunat commented Jun 29, 2022

I think the main platform using gcc10 is i686-linux now?

@ofborg ofborg bot requested review from Ericson2314 and Synthetica9 June 29, 2022 08:19
@vcunat vcunat marked this pull request as ready for review June 29, 2022 09:52
@vcunat
Copy link
Member Author

vcunat commented Jun 29, 2022 •
edited
Loading

I checked i686-linux by building wine, requiring something like 700 builds (including gfortran).

@vcunat vcunat mentioned this pull request Jul 1, 2022
Closed
13 tasks
@vcunat vcunat merged commit 97be985 into NixOS:staging Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trofi trofi trofi approved these changes

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

@Synthetica9 Synthetica9 Awaiting requested review from Synthetica9

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 501+ 10.rebuild-linux: 1001-2500 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vcunat @trofi