python310Packages.setuptools-scm: fix cross compile of dependents #179728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Packages depending on setuptools-scm need the setuptools module at build time. Add setuptools to the propagatedBuildInputs so this is guaranteed. This fixes cross compile of the dependent packages.
squalus
added
the
6.topic: cross-compilation
|
cc @SuperSandro2000. You suggested using |
13 tasks
|
@GrahamcOfBorg eval |
dotlambda
approved these changes
Jun 30, 2022
Merged
1 task
|
Successfully created backport PR #184549 for |
|
We should be able to somewhat better detect when we're missing setuptools with #185815. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Packages depending on setuptools-scm need the setuptools module at build time. Add setuptools to the propagatedBuildInputs so this is guaranteed. This fixes cross compile of the dependent packages.
For example, these builds will now succeed:
nix-build -A pkgsCross.aarch64-multiplatform.python310Packages.zippnix-build -A pkgsCross.aarch64-multiplatform.python310Packages.importlib-resourcesBefore this change, it would fail with this error:
ModuleNotFoundError: No module named 'setuptools'Merging to staging as it causes a mass rebuild.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes