haskellPackages.rio: skip a broken test on aarch64-darwin #179925
Conversation
andrew-d
requested review from
cdepillabout,
sternenseemann and
maralorn
as code owners
| # same as above, but called from rio; 'xit' skips a test | ||
| rio = overrideCabal (drv: { | ||
| preConfigure = '' | ||
| sed -i 's/\bit /xit /g' test/RIO/FileSpec.hs | ||
| ''; | ||
| }) super.rio; |
There was a problem hiding this comment.
Could you report this upstream and put a link to the github issue here so we have some way of tracking when this is fixed?
There was a problem hiding this comment.
@cdepillabout - It's the same issue as above (fpco/unliftio#87); do you want me to leave the same comment here?
There was a problem hiding this comment.
I'm not super familiar with the development of rio and unliftio, but it looks like they are developed in separate repos?
My guess is that posting an additional issue to the rio repo, so that we can track when the tests are fixed, would be helpful for us.
Although maybe you're trying to say that these failing rio tests would also be fixed as soon at the unliftio issue is fixed? Like, this isn't an issue directly with rio, but it is just an effect of unliftio being broken? In which case, could you update the issue so that the maintainers here in Nixpkgs would know that this override for rio could be removed as soon as the linked unliftio issue has been closed?
There was a problem hiding this comment.
@cdepillabout - Yes, sorry, should have been more clear. These failing rio tests will be fixed as soon as the unliftio tests are fixed; the issue is with unliftio, and rio just calls into the functions with an issue. I updated the comment here; is that better?
There was a problem hiding this comment.
Great, very easy to understand now!
|
Please rebase on |
andrew-d
force-pushed
the
andrew/rio-skip-broken-test
branch
from
6691839
to
4efb405
Compare
|
@cdepillabout - Rebased and changed the merge branch; does this look right? This is my first Haskell package change in nixpkgs. |
andrew-d
force-pushed
the
andrew/rio-skip-broken-test
branch
from
4efb405
to
f867d66
Compare
andrew-d
force-pushed
the
andrew/rio-skip-broken-test
branch
from
f867d66
to
3f4d5f2
Compare
|
Thanks a lot, this looks good! We always love to get these types of fixes! |
Description of changes
riohas tests that don't work onaarch64-darwin, and are essentially the same as theunliftiotestst that were skipped in #135453. Let's skip these in theriotest suite as well. Along with #179924 this unbreaksgit-annexon my M1 machine.Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes