Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python310Packages.google-auth: remove pyopenssl #180124

Merged
merged 1 commit into from
Jul 4, 2022
Merged

python310Packages.google-auth: remove pyopenssl #180124

merged 1 commit into from
Jul 4, 2022

Conversation

SuperSandro2000
Copy link
Member

Pyopenssl is in extras_require (optional), and only needed if mTLS feature is
enabled (disabled by default) googleapis/google-auth-library-python#697

This will also make google-auth available on aarch64-darwin since
pyopenssl is broken #172397

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@azuwis @SuperSandro2000
python310Packages.google-auth: remove pyopenssl
669577c 
Pyopenssl is in `extras_require` (optional), and only needed if mTLS feature is
enabled (disabled by default) googleapis/google-auth-library-python#697

This will also make google-auth available on aarch64-darwin since
pyopenssl is broken NixOS#172397
@SuperSandro2000 SuperSandro2000 mentioned this pull request Jul 4, 2022
Closed
13 tasks
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 101-500 10.rebuild-linux: 101-500 labels Jul 4, 2022
@SuperSandro2000 SuperSandro2000 merged commit d86fe16 into NixOS:master Jul 4, 2022
@SuperSandro2000 SuperSandro2000 deleted the google-auth-pyopenssl branch July 4, 2022 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 101-500 10.rebuild-linux: 101-500 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SuperSandro2000 @azuwis